Merged
Conversation
+ the first few tests for Select.Async, using the shallow renderer + removed redundant asyncOptions tests from Select-test + Changes Select.Async thenPromise to return the resulting promise if handled with promises - no change to usage, but makes testing easier as it is possible to just wait for the returned promise from thenPromise to complete before asserting the changes. + Added dev dependency to unexpected-react, to ease testing with the shallow renderer
Documented in the test case Changed the cache checking to start with the full search string, and then decrease the length.
The DOM is still needed for the other tests, and `npm test` may run the async tests first. This means React is already required, and has already decided that there is no DOM, hence `TestUtils.renderIntoDocument` won't work. Adding the DOM emulation to Async-test fixes this problem.
Treats as if the options list was empty
Owner
|
Woo!! 🎉 🎈 |
Owner
|
So great, thanks @bruderstein 😀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for Select.Async
These tests use the shallow renderer to test Select.Async. There's one bug fix, for a minor edge case in
9aa600b to do with the cache and out-of-order responses.
Fixes #615