Merged
Conversation
Owner
|
I should have known this was going to happen. Sorry @alyssaBiasi, there are conflicts now that #655 is in - would you mind updating your branch please and I'll merge this? Thanks! |
c211467 to
0ee697c
Compare
Contributor
Author
|
Ha no worries @JedWatson. I've rebased the branch and amended the commit. Now this PR just adds the |
Owner
|
Neat, thanks @alyssaBiasi! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to render custom icons as a part of the Select placeholder, we need to be able to provide styled HTML elements.
This PR:
Addselementto the expectedplaceholderprop typesnodeto the expectedplaceholderprop type forAsyncCustomComponentsexample in the docsI wasn't sure if it's better to add another prop (
placeholderComponentor<insert better name>) in order to keep theplaceholderprop a consistent type. Thoughts?