Fix blur handler on IE where menu ref is undefined#661
Merged
JedWatson merged 2 commits intoJedWatson:masterfrom Dec 15, 2015
gaastonsr:fix-ie-blur-2
Merged
Fix blur handler on IE where menu ref is undefined#661JedWatson merged 2 commits intoJedWatson:masterfrom gaastonsr:fix-ie-blur-2
JedWatson merged 2 commits intoJedWatson:masterfrom
gaastonsr:fix-ie-blur-2
Conversation
src/Select.js
Outdated
Contributor
There was a problem hiding this comment.
@gaastonsr findDOMNode is unnecessary in react 0.14 as this.refs.menu is a DOM Node. see https://facebook.github.io/react/blog/2015/10/07/react-v0.14.html
Author
There was a problem hiding this comment.
Thanks, I'll update this and check if I can fix #649.
React 0.14 already returns the DOM node.
Author
|
I updated the branch with the fixes pointed out by @cloudkite and verified it fixes #649. |
Owner
|
Thanks @gaastonsr! really appreciate this :) |
JedWatson
added a commit
that referenced
this pull request
Dec 15, 2015
Fix blur handler on IE where menu ref is undefined
Author
|
Thank you for merging. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On IE when the input is blurred it fails because on isEqualNode does not accept undefined or null values.
This re-introduces the fix on #539 and checks menuDOM is not undefined/null.