Skip to content

Big Upgrade/rewrite#680

Closed
nmn wants to merge 3 commits intoJedWatson:masterfrom
nmn:big-rewrite-pr
Closed

Big Upgrade/rewrite#680
nmn wants to merge 3 commits intoJedWatson:masterfrom
nmn:big-rewrite-pr

Conversation

@nmn
Copy link

@nmn nmn commented Dec 19, 2015

An ongoing place to keep my work to overhaul the component, clean-up build process and add features and flexibility.

  • Migrate build process from gulp to simple NPM scripts
    • build examples
    • Watch for changes while building examples
    • build for NPM (with Watch support)
    • Add dev server and livereload.
    • Add other scripts for verison bump etc.
    • remove the old gulp build process
  • ignore all the built files from git
  • add a .npmignore to include those files for npm (there was a suggestion of using a whitelist but that will be more painful)
  • allow users to pass in customRenderLabel methods as a child instead.
    • allow passing custom optionRenderers
    • allow passing custom valueRenderers
      So, instead of:
<Select
    {...otherProps}
    optionRenderer={this.renderOption} />

You can do this:

<Select {...otherProps}>
    <Option>
        {this.renderOption}
    </Option>
</Select>
  • Make more parts of the UI customizable.
    • Custom Component for OptionsList
    • Custom Component for Search field
    • Custom Component for Toolbars etc
    • Custom Component for SearchField

(probably not going to be handled in this PR)

  • Any possible solution to make CSS better
  • migrate the testing system to use expect-jsx, and airbnb/enzyme. (mocha stays on, wallaby.js I don't know anything about)

@nmn
Copy link
Author

nmn commented Dec 19, 2015

Obviously, don't merge this yet. Just leaving it here for discussion, code review etc.

@SylarRuby
Copy link

Id love this. I have to clear my rails cache then npm install for changes to show each and everytime. Its time consuming.

@nmn
Copy link
Author

nmn commented Mar 2, 2016

I've done a refactor to put menu in it's own component with list culling. This is just a proof-of-concept, and is causing some problems in the other cases.

I'm going to now start a complete re-write of React-Select. I'll look around for any work already started on that goal, so I don't duplicate work.

@JedWatson

@idoo idoo mentioned this pull request May 18, 2016
@nmn nmn closed this May 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants