Skip to content

Async options with Promises - Promise object bug#941

Merged
JedWatson merged 1 commit intoJedWatson:masterfrom
VladimirPal:async_promise_bug
May 7, 2016
Merged

Async options with Promises - Promise object bug#941
JedWatson merged 1 commit intoJedWatson:masterfrom
VladimirPal:async_promise_bug

Conversation

@VladimirPal
Copy link
Contributor

@VladimirPal VladimirPal force-pushed the async_promise_bug branch from 694b3cc to 5df5fa2 Compare May 6, 2016 11:05
@VladimirPal VladimirPal closed this May 6, 2016
@VladimirPal VladimirPal reopened this May 6, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.909% when pulling 5df5fa2 on VladimirPal:async_promise_bug into b21f70e on JedWatson:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.909% when pulling 5df5fa2 on VladimirPal:async_promise_bug into b21f70e on JedWatson:master.

@tonydecat tonydecat mentioned this pull request May 6, 2016
@JedWatson
Copy link
Owner

@VladimirPal wow, thanks for not just fixing this but adding a compete example! great work 👍

@f2net
Copy link

f2net commented May 18, 2016

In the /lib folder I still see the old Select.js without this fix. Why?

Thank you,
Matteo Frana

@VladimirPal
Copy link
Contributor Author

@f2net It's because lib folder builds automatically after releasing new version, looks like you have to build it manually:
cd node_modules/react-select
npm install && npm build

@VladimirPal
Copy link
Contributor Author

@JedWatson Maybe you can build current state of project or release new version? I think this bug is pretty important

@f2net
Copy link

f2net commented May 18, 2016

@JedWatson @VladimirPal I agree, I think the current state should be built, otherwise who installs the package via npm without building gets the [Promise object] bug.
Thank you for this great component.

@eliseumds
Copy link

May we have a release?

@f2net
Copy link

f2net commented May 30, 2016

Could you update the /lib version too, since the file in the /lib folder is still bugged?
Every time I distribute an app with react-select async I have to manually change line 390 of Select.js in /lib to:

if (nextState != null && typeof nextState !== 'object') {

Thank you,
Matteo

@jeffreybrowning
Copy link

I would love a release.

@khankuan
Copy link
Contributor

khankuan commented Jun 6, 2016

@JedWatson any chance of a release soon? :)

@TrevorBurnham
Copy link

FYI I've published a release of the react-select-plus with this patch, 1.0.0-beta13.patch1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants