style prop warning - can be either object or array#976
Closed
andreigec wants to merge 1 commit intoJedWatson:masterfrom
andreigec:propwarning
Closed
style prop warning - can be either object or array#976andreigec wants to merge 1 commit intoJedWatson:masterfrom andreigec:propwarning
andreigec wants to merge 1 commit intoJedWatson:masterfrom
andreigec:propwarning
Conversation
Collaborator
|
@andreigec, just wanted to check in with this PR and clarify its use, as React still doesn't support an array in style props as of React 16 |
Owner
|
Looking further into this, react-dom doesn't support arrays for styles - see facebook/react#2196 So I don't think it's a good idea to support the propType |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
had warnings with the style prop type