Skip to content

Conversation

@tuxuser
Copy link

@tuxuser tuxuser commented Oct 3, 2018

  • Added tests for TcpHandle.init and AdbCommands.ConnectDevice
  • Rewrite Usb/TcpStub from the real class
  • Add mocking for AdbCommands test
  • Add mock package to tox deps
  • Revert version bump

I hope it helps for a successful merge

@JeffLIrion
Copy link
Owner

Thank you!

@JeffLIrion JeffLIrion merged commit a8938ca into JeffLIrion:master Oct 4, 2018
@tuxuser
Copy link
Author

tuxuser commented Oct 4, 2018

Sorry for the inconvenience, there is a little problem with my PR that prevents merging with the Google repo currently.

  1. You have to change my commits to my Google email address to be recognized by the Google CLA bot (yes, I signed the agreement). Atm I the commits are signed with a noreply github email: 462620+tuxuser@users.noreply.github.com
    Correct email address: tuxuser360 usual_email_separator gmail.com
    Instructions to do so: https://help.github.com/articles/changing-author-info
  2. You need to comment on the Google PR again with "I signed it!" to re-trigger the verification.
  3. If this fails, feel free to rewrite the commits under you name/email.

@tuxuser
Copy link
Author

tuxuser commented Oct 4, 2018

We did it :)

@tuxuser tuxuser deleted the for_jeff branch October 6, 2018 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants