Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 20, 2026

The current version of JD.MSBuild.Fluent (v1.3.8) supports translating C# comments to XML comments in generated MSBuild files. The fluent definition was still using v1.0.2 without comment support, causing generated files to lack documentation present in the hand-maintained versions.

Changes:

  • Upgraded JD.MSBuild.Fluent package reference from v1.0.2 to v1.3.8
  • Added multi-line block comments to DefinitionFactory.cs matching the existing .props and .targets file documentation:
    • Props: Enablement, Granular Feature Control, Script Execution Control, Fingerprinting Control
    • Targets: Task Assembly Path, MSBuild task registration, Docker Build Pipeline, Build/Run/Publish/Clean Integration headers, Dockerfile validation

Example:

// Before (v1.0.2 - no comment support)
props.Comment("Disabled by default. Users opt-in by setting DockerEnabled=true");
props.Property("DockerEnabled", "false", condition: "'$(DockerEnabled)'==''");

// After (v1.3.8 - multi-line comments)
props.Comment(@"
  Enablement: Disabled by default. Users opt-in by setting DockerEnabled=true.
  
  To enable Docker integration, set:
    <DockerEnabled>true</DockerEnabled>
");
props.Property("DockerEnabled", "false", condition: "'$(DockerEnabled)'==''");

This ensures regenerated MSBuild files from the fluent definition retain documentation quality equivalent to the current hand-maintained versions.

Original prompt

This section details on the original issue you should resolve

<issue_title>[Chore] Review Pre-JD.MSBuild.Fluent-Migration State and Comments, and Add to Codebase</issue_title>
<issue_description>The current version of JD.MSBuild.Fluent (https://github.com/jerrettdavis/JD.MSBuild.Fluent)(1.3.8) supports adding comments around your fluent code to have translated into the generated XML output. We need to review the pre-update state and ensure we add the appropriate comments in the appropriate areas to ensure our generated outputs are correct and what we expected pre-migration.</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits January 20, 2026 03:37
…onFactory

Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com>
Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com>
Copilot AI changed the title [WIP] Review and add comments for JD.MSBuild.Fluent migration Upgrade JD.MSBuild.Fluent to v1.3.8 and add XML comment blocks to DefinitionFactory Jan 20, 2026
Copilot AI requested a review from JerrettDavis January 20, 2026 03:47
@JerrettDavis JerrettDavis marked this pull request as ready for review January 20, 2026 04:01
@github-actions
Copy link

Code Coverage

Summary
  Generated on: 01/20/2026 - 04:02:14
  Coverage date: 01/20/2026 - 04:02:12
  Parser: Cobertura
  Assemblies: 0
  Classes: 0
  Files: 0
  Line coverage: 
  Covered lines: 0
  Uncovered lines: 0
  Coverable lines: 0
  Total lines: 0
  Covered branches: 0
  Total branches: 0
  Method coverage: 
  Full method coverage: 
  Covered methods: 0
  Fully covered methods: 0
  Total methods: 0
No assemblies have been covered.

@JerrettDavis JerrettDavis merged commit 123dd21 into main Jan 20, 2026
7 checks passed
@JerrettDavis JerrettDavis deleted the copilot/review-fluent-migration-comments branch January 20, 2026 04:07
@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (844912b) to head (9d7c67b).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@    Coverage Diff     @@
##   main   #11   +/-   ##
==========================
==========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Chore] Review Pre-JD.MSBuild.Fluent-Migration State and Comments, and Add to Codebase

2 participants