Conversation
HKaras
reviewed
Aug 6, 2023
| Choosing a time range | ||
| ************************* | ||
|
|
||
| The time range depends on the expected range of distances, but is typically in the range of 0.5 to several microseconds. To construct a time vector, use the ``linspace`` function from NumPy: :: |
Member
There was a problem hiding this comment.
I am unsure of this wording here. When creating the model you have already got your data, so you aren't so much choosing your time range more inputting it. I also wouldn't say that the time range is dependent on the distances, more the range of extractable distances is dependent upon the time axis.
Additionally most people use a tau1 of 0.4us for 4pDEER, so the range starts before 0.5 us.
HKaras
previously approved these changes
Aug 6, 2023
Member
HKaras
left a comment
HKaras
left a comment
There was a problem hiding this comment.
It all looks good except I don't fully agree with the language around 'Choosing a time range'.
Collaborator
Author
|
I modified the language. Good now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.