Conversation
stestoll
changed the title
stestoll
changed the title
HKaras
approved these changes
Aug 9, 2023
Member
HKaras
left a comment
HKaras
left a comment
There was a problem hiding this comment.
All looks good. Only question is if we really need both the svg and png versions or we could move to only having the single svg.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4-pulse DEER: t=0 is right after second observer pulse.
RIDME: t=0 is tau1 after second pulse.
This is inconsistent. Probably the least disruptive fix is to update the RIDME t definition to match the 4-pulse DEER definition.
This fixes #433.