refactor: streamline GraphQL schema by removing deprecated fields and… by mikeallisonJS · Pull Request #8915 · JesusFilm/core

mikeallisonJS · 2026-03-26T22:56:54Z

… updating input types

Removed cardBlockCreate and cardBlockUpdate mutations from api-journeys schema.
Updated adminJourney query to align with modern API structure.
Refactored DateTimeFilter input type for better clarity and usage.
Adjusted various GraphQL types to ensure consistency across schemas.
Cleaned up unused imports and types in resolver files to enhance maintainability.

Summary by CodeRabbit

Release Notes

Removed Features
- Removed icon block creation capability from the API.
- Removed admin journey query endpoint.
API Reorganization
- Migrated card block update functionality between services.
- Reorganized button block and journey profile management operations for improved architecture.
- Streamlined GraphQL operation routing across federated services.

… updating input types - Removed `cardBlockCreate` and `cardBlockUpdate` mutations from `api-journeys` schema. - Updated `adminJourney` query to align with modern API structure. - Refactored `DateTimeFilter` input type for better clarity and usage. - Adjusted various GraphQL types to ensure consistency across schemas. - Cleaned up unused imports and types in resolver files to enhance maintainability.

coderabbitai · 2026-03-26T22:57:19Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 2dfaec83-1301-4b73-b0e6-be91e4486c7f

📥 Commits

Reviewing files that changed from the base of the PR and between 4936a96 and d302f74.

⛔ Files ignored due to path filters (1)

apis/api-journeys/src/app/__generated__/graphql.ts is excluded by !**/__generated__/**

📒 Files selected for processing (3)

apis/api-gateway/schema.graphql
apis/api-journeys-modern/schema.graphql
apis/api-journeys/schema.graphql

💤 Files with no reviewable changes (1)

apis/api-journeys/schema.graphql

✅ Files skipped from review due to trivial changes (1)

apis/api-journeys-modern/schema.graphql

Walkthrough

This pull request restructures GraphQL Federation routing across multiple services by moving field implementations between the api-journeys and api-journeys-modern graphs. It relocates cardBlockUpdate, iconBlockCreate, and adminJourney to api-journeys-modern, removes @override directives from several mutations and queries, and removes the corresponding implementations and tests from api-journeys.

Changes

Cohort / File(s)	Summary
API Gateway Federation Routing `apis/api-gateway/schema.graphql`	Re-ordered and re-scoped Mutation and Query fields with updated `@join__field` directives. Added override directives for `cardBlockUpdate` and `iconBlockCreate` routing to api-journeys-modern, removed overrides from `buttonBlockCreate`, `buttonBlockUpdate`, and `journeyProfileUpdate`. Relocated `adminJourney` with override directive.
API Journeys-Modern Schema `apis/api-journeys-modern/schema.graphql`	Removed `@override(from: "api-journeys")` directives from `buttonBlockCreate`, `buttonBlockUpdate`, `journeyProfileUpdate` mutations and `getUserRole` query; field signatures otherwise unchanged.
API Journeys-Modern Override Configuration `apis/api-journeys-modern/src/schema/block/button/...`, `apis/api-journeys-modern/src/schema/block/card/...`, `apis/api-journeys-modern/src/schema/journeyProfile/...`, `apis/api-journeys-modern/src/schema/userRole/...`	Removed override configuration from `buttonBlockCreate.mutation.ts`, `buttonBlockUpdate.mutation.ts`, `journeyProfileUpdate.mutation.ts`, and `getUserRole.query.ts`; repositioned override in `cardBlockCreate.mutation.ts`.
API Journeys Schema Removal `apis/api-journeys/schema.graphql`, `apis/api-journeys/src/app/modules/.../...graphql`	Removed `adminJourney` query and `cardBlockUpdate`, `iconBlockCreate` mutations from extended Query/Mutation types; deleted corresponding input types `CardBlockUpdateInput` and `IconBlockCreateInput`.
API Journeys Resolver Removal `apis/api-journeys/src/app/modules/journey/journey.resolver.ts`, `apis/api-journeys/src/app/modules/block/card/card.resolver.ts`, `apis/api-journeys/src/app/modules/block/icon/icon.resolver.ts`	Removed resolver implementations for `adminJourney`, `cardBlockUpdate`, and `iconBlockCreate`; includes deletion of CASL authorization guards, Prisma queries, and error handling logic.
API Journeys Test Cleanup `apis/api-journeys/src/app/modules/journey/journey.resolver.spec.ts`, `apis/api-journeys/src/app/modules/block/card/card.resolver.spec.ts`, `apis/api-journeys/src/app/modules/block/icon/icon.resolver.spec.ts`	Removed test suites for `adminJourney` (4 tests), `cardBlockUpdate` (multiple auth/validation tests), and `iconBlockCreate` (creation and authorization tests); simplified test module providers.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

chore: migrate cardblockupdate modern #8847: Involves migration of cardBlockUpdate to api-journeys-modern graph with gateway join field routing updates.
chore: migrate buttonblockupdate #8835: Modifies GraphQL routing for button block mutations, adjusting @join__field and @override directives between api-journeys and api-journeys-modern.

Suggested reviewers

csiyang

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title partially describes the main changes but is incomplete due to truncation; it mentions removing deprecated fields but doesn't specify which ones or what the full scope entails.	Complete the title to clearly specify the main changes, such as 'refactor: streamline GraphQL schema by removing deprecated block mutations and adminJourney query' to be more informative.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch 00-00-MA-chore-modern-override-cleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-03-26T22:57:51Z

	Warnings
⚠️	❗ Big PR (697 changes)

(change count - 697): Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

Generated by 🚫 dangerJS against d302f74

nx-cloud · 2026-03-26T22:58:12Z

View your CI Pipeline Execution ↗ for commit d302f74

Command	Status	Duration	Result
`nx run journeys-admin-e2e:e2e`	✅ Succeeded	35s	View ↗
`nx run journeys-e2e:e2e`	✅ Succeeded	29s	View ↗
`nx run watch-e2e:e2e`	✅ Succeeded	24s	View ↗
`nx run videos-admin-e2e:e2e`	✅ Succeeded	6s	View ↗
`nx run resources-e2e:e2e`	✅ Succeeded	21s	View ↗
`nx run player-e2e:e2e`	✅ Succeeded	3s	View ↗
`nx run short-links-e2e:e2e`	✅ Succeeded	9s	View ↗
`nx run-many --target=vercel-alias --projects=jo...`	✅ Succeeded	2s	View ↗
`Additional runs (20)`	✅ Succeeded	...	View ↗

☁️ Nx Cloud last updated this comment at 2026-04-07 21:14:02 UTC

github-actions · 2026-03-26T23:00:17Z