fix: social media step spacing, preview size, and UI cleanup (NES-1530)#8962
Merged
fix: social media step spacing, preview size, and UI cleanup (NES-1530)#8962
Conversation
- Reduce Stack gap from 48px to 20px and remove vertical padding - Remove CardHeader (avatar, skeleton title) and CardActions (like/comment/share icons) - Replace card shadow with outlined variant using divider border color - Resize social preview card media to 215x147px - Hide helper/assisting text on TitleEdit and DescriptionEdit fields Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdded optional Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit a72bc5b
☁️ Nx Cloud last updated this comment at |
Contributor
|
The latest updates on your projects.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
apps/journeys-admin/src/components/TemplateCustomization/MultiStepForm/Screens/SocialScreen/SocialScreenSocialImage/SocialScreenSocialImage.tsx (1)
31-33: Rename props interface to match repository convention.Please rename the interface to
SocialScreenSocialImagePropsfor consistency with the TypeScript props naming rule.♻️ Proposed refactor
-interface SocialScreenSocialImage { +interface SocialScreenSocialImageProps { hideAdornments?: boolean } export function SocialScreenSocialImage({ hideAdornments = false -}: SocialScreenSocialImage): ReactElement { +}: SocialScreenSocialImageProps): ReactElement {As per coding guidelines, "Props interfaces must follow naming convention {ComponentName}Props".
Also applies to: 53-55
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/journeys-admin/src/components/TemplateCustomization/MultiStepForm/Screens/SocialScreen/SocialScreenSocialImage/SocialScreenSocialImage.tsx` around lines 31 - 33, The props interface currently named SocialScreenSocialImage should be renamed to SocialScreenSocialImageProps to follow the {ComponentName}Props convention; update the interface declaration (SocialScreenSocialImage → SocialScreenSocialImageProps) and replace all usages/references of SocialScreenSocialImage in this file (including the component signature and any FC or prop-type annotations around SocialScreenSocialImage) with SocialScreenSocialImageProps so the component and its props type remain consistent.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@apps/journeys-admin/src/components/TemplateCustomization/MultiStepForm/Screens/SocialScreen/SocialScreenSocialImage/SocialScreenSocialImage.tsx`:
- Around line 31-33: The props interface currently named SocialScreenSocialImage
should be renamed to SocialScreenSocialImageProps to follow the
{ComponentName}Props convention; update the interface declaration
(SocialScreenSocialImage → SocialScreenSocialImageProps) and replace all
usages/references of SocialScreenSocialImage in this file (including the
component signature and any FC or prop-type annotations around
SocialScreenSocialImage) with SocialScreenSocialImageProps so the component and
its props type remain consistent.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: b3df4e05-ad35-47aa-8d07-060e9ea7449f
📒 Files selected for processing (4)
apps/journeys-admin/src/components/Editor/Slider/Settings/SocialDetails/DescriptionEdit/DescriptionEdit.tsxapps/journeys-admin/src/components/Editor/Slider/Settings/SocialDetails/TitleEdit/TitleEdit.tsxapps/journeys-admin/src/components/TemplateCustomization/MultiStepForm/Screens/SocialScreen/SocialScreen.tsxapps/journeys-admin/src/components/TemplateCustomization/MultiStepForm/Screens/SocialScreen/SocialScreenSocialImage/SocialScreenSocialImage.tsx
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@apps/journeys-admin/src/components/Editor/Slider/Settings/SocialDetails/TitleEdit/TitleEdit.tsx`:
- Around line 88-92: The helper text currently short-circuits on hideHelperText
and therefore suppresses validation errors; update the helper text logic in
TitleEdit (where hideHelperText and errors.seoTitle are used) so validation
messages always display: return errors.seoTitle when present, otherwise show the
default guidance only when hideHelperText is false (i.e., helperText =
errors.seoTitle ?? (hideHelperText ? undefined : t('Recommended length: 5
words'))), preserving the existing type cast for errors.seoTitle.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: dc0ef5b9-cb64-4366-8926-ca75ad1383d2
📒 Files selected for processing (2)
apps/journeys-admin/src/components/Editor/Slider/Settings/SocialDetails/DescriptionEdit/DescriptionEdit.tsxapps/journeys-admin/src/components/Editor/Slider/Settings/SocialDetails/TitleEdit/TitleEdit.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
- apps/journeys-admin/src/components/Editor/Slider/Settings/SocialDetails/DescriptionEdit/DescriptionEdit.tsx
mikeallisonJS
previously approved these changes
Apr 9, 2026
jianwei1
approved these changes
Apr 13, 2026
tanflem
pushed a commit
that referenced
this pull request
Apr 13, 2026
…0) (#8962) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes NES-1530
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
Style
Refactor