Conversation
Exposes the Firebase UID stored on Integration.userId as a scalar field on IntegrationGoogle, consistent with 10+ other types that already expose userId (UserJourney, UserRole, JourneyProfile, etc.). This enables frontend consumers to filter integrations by the authenticated user without relying on the federated User entity, which resolves to a different ID format (Prisma UUID). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
WalkthroughThe PR reorganizes GraphQL schemas across API services, relocating the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 5604dc9
☁️ Nx Cloud last updated this comment at |
|
I see you added the "on stage" label, I'll get this merged to the stage branch! |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Merge conflict attempting to merge this into stage. Please fix manually. |
|
The latest updates on your projects.
|
|
The latest updates on your projects.
|
|
The latest updates on your projects.
|
|
The latest updates on your projects.
|
|
The latest updates on your projects.
|
|
The latest updates on your projects.
|
|
The latest updates on your projects.
|
|
Merge conflict attempting to merge this into stage. Please fix manually. |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
apis/api-gateway/schema.graphql (1)
1848-1848: Consider documenting the identifier format onuserId.Line 1848 now sits next to
user: User, but those IDs come from different domains (Firebase UID vs federated user UUID). A short field description in the source subgraph schema would make that distinction obvious to clients.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apis/api-gateway/schema.graphql` at line 1848, Add a short GraphQL field description/comment for the userId field to clarify which identifier format it holds (e.g., Firebase UID vs federated user UUID) since it sits next to user: User and the two come from different domains; update the schema entry for userId to include that descriptive text so clients know which ID to supply/expect and which system it originates from.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@apis/api-gateway/schema.graphql`:
- Line 1848: Add a short GraphQL field description/comment for the userId field
to clarify which identifier format it holds (e.g., Firebase UID vs federated
user UUID) since it sits next to user: User and the two come from different
domains; update the schema entry for userId to include that descriptive text so
clients know which ID to supply/expect and which system it originates from.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 9455e62c-c99c-4695-b7a2-4e40eb9f806f
⛔ Files ignored due to path filters (3)
apis/api-journeys/src/__generated__/graphql.tsis excluded by!**/__generated__/**apis/api-journeys/src/app/__generated__/graphql.tsis excluded by!**/__generated__/**libs/shared/gql/src/__generated__/graphql-env.d.tsis excluded by!**/__generated__/**
📒 Files selected for processing (5)
apis/api-gateway/schema.graphqlapis/api-journeys-modern/schema.graphqlapis/api-journeys-modern/src/schema/integration/google/google.tsapis/api-journeys/schema.graphqlapis/api-journeys/src/app/modules/integration/google/google.graphql
#8967) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Summary
userId(Firebase UID) as a scalar field onIntegrationGooglein bothapi-journeysandapi-journeys-modernuserId(UserJourney, UserRole, JourneyProfile, etc.)Userentity, which resolves to a different ID format (Prisma UUID vs Firebase UID)Context
This is part 1 of 2 for NES-1492. The frontend PR (#8958) depends on this being deployed first.
Test plan
userIdfield is queryable onIntegrationGooglevia GraphQLintegrationsquery continues to work without changes🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
userIdfield to Google Integration objects.notesfield to VideoBlock for template adapters reference.Schema Updates