chore: imageblockupdate modern by mikeallisonJS · Pull Request #8981 · JesusFilm/core

mikeallisonJS · 2026-04-08T19:23:24Z

Summary by CodeRabbit

New Features
- Added a new mutation to update image blocks with configurable properties.
Tests
- Added comprehensive test coverage for the image block update mutation, including authorization and validation scenarios.

…api-journeys-override-skill

…odify existing iconBlockCreate mutation for modern API

…tions for iconBlock mutations

…ization patterns in API journeys

…ck mutation in API gateway

coderabbitai · 2026-04-08T19:23:41Z

Walkthrough

This PR adds a new imageBlockUpdate GraphQL mutation to the api-journeys-modern service and updates the API gateway schema federation to route the mutation through the modern service with a deprecation override for the legacy api-journeys service.

Changes

Cohort / File(s)	Summary
GraphQL Schema Federation `apis/api-gateway/schema.graphql`	Updated the `Mutation.imageBlockUpdate` directive to target `API_JOURNEYS_MODERN` instead of `API_JOURNEYS`, establishing federation routing with an override to the legacy service.
API Journeys Modern Schema `apis/api-journeys-modern/schema.graphql`	Added new `imageBlockUpdate` mutation field accepting `id`, `input`, and optional `journeyId` parameters, returning `ImageBlock` with `@override` directive indicating it replaces the legacy api-journeys field.
Image Block Update Mutation Implementation `apis/api-journeys-modern/src/schema/block/image/imageBlockUpdate.mutation.ts`	Implemented the mutation resolver with authentication requirement, block authorization check, input transformation, and Prisma transactional updates to both block and journey records.
Image Block Update Tests `apis/api-journeys-modern/src/schema/block/image/imageBlockUpdate.mutation.spec.ts`	Added comprehensive Jest test suite covering authorization scenarios (authorized/unauthorized), full and partial input updates, Prisma call verification, and GraphQL response validation.
Module Integration `apis/api-journeys-modern/src/schema/block/image/index.ts`	Imported the new `imageBlockUpdate.mutation` module as a side effect to register the mutation in the schema.

Sequence Diagram(s)

sequenceDiagram
    actor Client
    participant GraphQL as GraphQL Resolver
    participant Auth as Authorization
    participant Transform as Input Transform
    participant DB as Prisma (Database)
    participant Response

    Client->>GraphQL: imageBlockUpdate(id, input, journeyId)
    GraphQL->>Auth: authorizeBlockUpdate(id, user)
    alt Authorized
        Auth-->>GraphQL: ✓ Permission granted
        GraphQL->>Transform: transformInput(input)
        Transform-->>GraphQL: transformed input
        GraphQL->>DB: block.update(where: {id}, data: {...})
        GraphQL->>DB: journey.update(where: {id}, data: {...})
        DB-->>GraphQL: updated ImageBlock
        GraphQL-->>Response: ImageBlock data
        Response-->>Client: mutation success
    else Unauthorized
        Auth-->>GraphQL: ✗ Permission denied
        GraphQL-->>Response: error: "User not allowed"
        Response-->>Client: error response
    end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

chore: imageblockcreate modern #8980: Added imageBlockCreate mutation to the same service with overlapping patterns for input transformation, authorization checks, and schema federation setup via @override directive.

Suggested reviewers

csiyang

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: migrating the imageBlockUpdate mutation to the modern API.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch 26-00-MA-chore-imageblockupdate-modern

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-04-08T19:24:47Z

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

_{To disable these notifications, a workspace admin can disable them in workspace settings.}

View your CI Pipeline Execution ↗ for commit 85d5e93

Command	Status	Duration	Result
`nx run journeys-e2e:e2e`	❌ Failed	4m 9s	View ↗

☁️ Nx Cloud last updated this comment at 2026-04-09 21:25:38 UTC

github-actions · 2026-04-08T19:27:22Z