Add e2e coverage for Watch, Docs, Journeys, Short-links, Videos admin, Resources#9040
Add e2e coverage for Watch, Docs, Journeys, Short-links, Videos admin, Resources#9040kiran-redhat wants to merge 4 commits intomainfrom
Conversation
Extend watch, watch-modern, docs, journeys, short-links, videos-admin, and resources e2e suites; wire resources deploy into daily e2e and pass optional secrets for short-link and videos-admin flows. Align journeys cold-load timeout with the 90s e2e rule.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
subject may not be emptytype may not be empty |
|
View your CI Pipeline Execution ↗ for commit 4816468
☁️ Nx Cloud last updated this comment at |
|
The latest updates on your projects.
|
|
The latest updates on your projects.
|
|
The latest updates on your projects.
|
|
The latest updates on your projects.
|
|
The latest updates on your projects.
|
|
The latest updates on your projects.
|
|
The latest updates on your projects.
|
…e2e-gap-coverage-ad59
…es from specific .env files - Replaced dotenv configuration with a custom loader for environment variables in multiple Playwright config files across various apps. - Enhanced test specifications to improve visibility checks and timeout handling in e2e tests for journeys and watch applications. - Updated selectors and assertions to ensure robustness in UI tests, particularly for dynamic content and navigation elements.
2 participants
Summary
Adds Playwright scenarios that were previously missing across several apps, and extends the scheduled e2e workflow to deploy and test resources alongside the other preview apps.
Changes
watch-e2e): Regression scan for badVideoCardhrefs; smoke for home link (non-English), language dialog combobox enablement, hero carousel swipe, and unmute → inline player controls on a chapter page.watch-modern-e2e): Asserts translated home copy on/and covers/modern-testcontent.docs-e2e): Sidebar navigation from Welcome → Basics → Architecture Concepts.journeys-e2e): Opens a second featured journey from/home(excluding Fact or Fiction); reduces Fact or Fiction visibility wait to 90s with an inline comment (repo e2e rule cap).short-links-e2e): Optional happy-path redirect whenSHORT_LINK_HAPPY_PATH_URLis set (skipped otherwise).videos-admin-e2e): Optional email/password sign-in to dashboard whenPLAYWRIGHT_VIDEOS_ADMIN_EMAIL/PLAYWRIGHT_VIDEOS_ADMIN_PASSWORDare set.resources-e2e): SameVideoCardhref regression as Watch..github/workflows/e2e-tests.yml): Addsresourcesto the deploy matrix,resources-e2eto manual dispatch options,RESOURCES_VERCEL_PROJECT_IDfor deploy, and forwards optional secrets for the new gated tests.Verification
pnpm exec nx run-many --target=lint --projects=watch-e2e,watch-modern-e2e,docs-e2e,short-links-e2e,journeys-e2e,videos-admin-e2e,resources-e2epnpm exec nx run-many --target=type-check --projects=watch-e2e,watch-modern-e2e,docs-e2e,short-links-e2e,journeys-e2e,videos-admin-e2e,resources-e2eFollow-up (repo configuration)
To enable the gated tests in CI, add GitHub Actions secrets:
SHORT_LINK_HAPPY_PATH_URL— full URL of a known-good short link in the stage/preview environment.PLAYWRIGHT_VIDEOS_ADMIN_EMAIL/PLAYWRIGHT_VIDEOS_ADMIN_PASSWORD— Firebase test user for videos-admin preview.Without these, the corresponding specs remain skipped and do not fail the suite.
Slack Thread