Draft
Conversation
|
🚅 Deployed to the forge-pr-752 environment in forge
1 service not affected by this PR
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a job-detail-first human subtitle review flow for Manager-generated VTT artifacts. Manager now mints short-lived review sessions, gates subtitle-review config, serves CORS-safe bootstrap/save APIs, stores reviewed VTT revisions as separate artifacts, and shows review actions/state from the job detail translation step. This also adds a small Forge-hosted
apps/subtitle-editorapp that exchanges launch codes, loads subtitles from Manager, lets reviewers edit VTT text, and saves reviewed revisions back.Root cause for the follow-up hardening: the initial happy path left three edge cases from review: bootstrap used token-frozen artifact state instead of latest reviewed state, missing subtitle-review config failed late, and popup-blocked fallback attempted a delayed
window.openthat browsers could still block.Work Loop
ce:plandonece:workdonece:reviewdonece:compounddoneNotes
docs/plans/2026-04-13-feat-manager-subtitle-review-editor-plan.mddocs/plans/2026-04-13-fix-subtitle-review-recovery-config-plan.mddocs/roadmap/media-generation/feat-081-manager-subtitle-review-editor.mddocs/solutions/ui-bugs/20260413-manager-subtitle-editor-popup-reload.md/tmp/forge-subtitle-smoke/:review-fixes-editor-after-save.png,review-fixes-job-reviewed.png,review-fixes-continue-loads-latest.pngValidation run locally after rebasing onto current
origin/main:pnpm --filter @forge/manager testpnpm --filter @forge/manager lintpnpm --filter @forge/manager typecheckCI=1 pnpm --filter @forge/manager buildpnpm --filter @forge/subtitle-editor testpnpm --filter @forge/subtitle-editor lintpnpm --filter @forge/subtitle-editor typecheckCI=1 NEXT_PUBLIC_MANAGER_BASE_URL=http://localhost:3002 pnpm --filter @forge/subtitle-editor buildpnpm run format:checkpnpm exec commitlint --from origin/main --to HEAD