Fixed Issue #1, Duplicate Code for t and vr.#4
Open
jayharris wants to merge 1 commit intoJetBrains:masterfrom
Open
Fixed Issue #1, Duplicate Code for t and vr.#4jayharris wants to merge 1 commit intoJetBrains:masterfrom
jayharris wants to merge 1 commit intoJetBrains:masterfrom
Conversation
…n new UntypedMemberTemplates group. Group can be used for future expansion on members that do not get type definitions.
|
Does this fix the following bug?
private readonly type fieldname;instead of private readonly bool fieldname; |
Author
|
Yes. Any of the It also renames the |
Author
|
I recently discovered that private bool fieldname = false;private readonly bool fieldname = false;Do we need both vr* and o* ? I do miss some simple documentation that lists all the cases and what variations are supported for each, but that is a separate issue. |
|
I think "vb" and "vrb" for a field declarations with and without readonly modifier is intuitive, but "nb" and "ob" is not. Maybe adapting the same naming, such as "nb" and "nrb" for declarations with default value assignment, with/without readonly modifier? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the issue with vr templates replicating, rather than getting the type definitions.
Moved the t templates to a new UntypedMemberTemplates group, as the test templates will not be appended with type definitions. Also, renamed the template from t to tm (Test Method) to allow for future test fixture, setup, and teardown templates.
Did not regenerate the Download files.