Skip to content

Ensure self to be a RawData object#180

Open
marcgurevitx wants to merge 1 commit intoJoeStrout:masterfrom
marcgurevitx:fix-rawdata-self-check
Open

Ensure self to be a RawData object#180
marcgurevitx wants to merge 1 commit intoJoeStrout:masterfrom
marcgurevitx:fix-rawdata-self-check

Conversation

@marcgurevitx
Copy link
Contributor

@marcgurevitx marcgurevitx commented Aug 4, 2024

In the current C++ implementation of RawData there's a bug: Methods with self param accept anything that has a _handle, even an open file object.

> f = @RawData.byte
> f file.open("x.ms")  // doesn't raise an error
... ///nonsense

This PR makes it raise an index error (just like in Mini Micro).

(edit: corrected the snippet.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant