Fix reorder-ctor warning when building MiniScript-cpp#194
Open
MineRobber9000 wants to merge 1 commit intoJoeStrout:masterfrom
Open
Fix reorder-ctor warning when building MiniScript-cpp#194MineRobber9000 wants to merge 1 commit intoJoeStrout:masterfrom
MineRobber9000 wants to merge 1 commit intoJoeStrout:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered these warnings while building MSRLWeb. Basically, the issue is that initializers run in order of their definition in the
classand not the order they're given on the constructor, so, for example, you might think this:Would initialize
barandbazto 0, but in reality,baris initialized first with whatever uninitialized value is inbaz, followed bybazbeing initialized to 0. In theory, this warning doesn't mean anything for MiniScript (both instances of this warning are for values being initialized to static values), but it doesn't cost much more than a few minutes of my time to fix this so that this warning doesn't appear when building a project with MiniScript.