Added the option to announce on chat the song that is now playing.#8
Open
daffwt221 wants to merge 4 commits intoJohn200410:masterfrom
Open
Added the option to announce on chat the song that is now playing.#8daffwt221 wants to merge 4 commits intoJohn200410:masterfrom
daffwt221 wants to merge 4 commits intoJohn200410:masterfrom
Conversation
Owner
|
Do you think you could go ahead and implement a setting to send the message client-side? You could use ChatUtils#print |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a boolean option to the HUD that, when enabled, announces the currently playing song in chat, including the artist and album name, using green text.
The current format is ">Now playing [song name] by [artist(s)] on [album]".
Useful for players who want to share the currently playing song in global chat.
Future improvements could include displaying it client-side as a sub-setting and allowing users to customize the chat message format.