Added corrections for rounded corners from V3.6.6 #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no backup files to github
no backup files on github
no backup files on github
edited to resolve conflicts with master
edited to resolve conflicts with master
edited to resolve conflicts with master
edited to resolve conflicts with master
deHarro
added a commit
to deHarro/pcbgcode
that referenced
this pull request
Dec 8, 2024
Merge pull request JohnAtl#26 from deHarro/endmill-holes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I applied my changes to the fork of Johns code in my Github account.
This should result in a version of pcb_gcode.ulp which has rounded corners fixed and milling holes bigger than the bit by helical drilling with a small(er) bit.