Refactor recorded method names in HeadlessAudioPlayer for consistency…#17
Merged
JohnLudlow merged 1 commit intomainfrom Apr 22, 2026
12-fix-headlessaudioplayer-recorded-method-name-strings-docsplansphase-2-consistency-fixesmd-phase-1
Conversation
JohnLudlow
added
area-lib
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the headless audio test double to record method names using nameof(...) (matching the public IAudioPlayer API), and aligns unit tests to assert against those recorded names rather than hard-coded string literals.
Changes:
- Update
HeadlessAudioPlayerto recordStartPlayback/StopPlayback/SetVolumevianameof(...)instead of"Play"/"Stop"/"SetVolume". - Update
HeadlessAudioPlayerTestsassertions to compare againstnameof(...)for the recorded method name values.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/GameEngineAdapter.Headless/HeadlessAudioPlayer.cs |
Records call method identifiers using nameof(...) for API-consistent naming. |
src/GameEngineAdapter.UnitTests/HeadlessAudioPlayerTests.cs |
Updates assertions to expect the new recorded method names. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JohnLudlow
deleted the
12-fix-headlessaudioplayer-recorded-method-name-strings-docsplansphase-2-consistency-fixesmd-phase-1
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor recorded method names in HeadlessAudioPlayer for consistency… in tests #12
Project : project link
Issue : Fix #12
PR Overview
Fix method name refs for renamed methods post-refactor
PR Detail
Fix method name refs for renamed methods post-refactor
PR Impact
None