Replace distutils with setuptools#2
Merged
sylvainemery merged 1 commit intoJohnPaulConcierge:masterfrom Jul 22, 2019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Poetry can not retrieve version because the
setup.pyfile usesdistutilswhich does not provide theegg_infocommand for depency resolution. When the command is not available, poetry tries to retrieve version and dependencies as strings insetup.pywith AST parsing which cannot interpret__version__variable. Because of that, Poetry thinks there is no available version and refuse to add dependency.Read more: python-poetry/poetry#673
While
distutilsdoes not provide capacity to generate theegg_infocommandsetuptoolscan and it is the now (as of 2019) recommended tool to generate package setup files.Here is an abstract from python official documentation:
source: https://packaging.python.org/guides/tool-recommendations/