Fix aarch64 linux builds#572
Merged
JohnnyMorganz merged 1 commit intoJohnnyMorganz:mainfrom Sep 12, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #572 +/- ##
=======================================
Coverage 97.82% 97.82%
=======================================
Files 14 14
Lines 5469 5469
=======================================
Hits 5350 5350
Misses 119 119 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
JohnnyMorganz
approved these changes
Sep 12, 2022
Owner
JohnnyMorganz
left a comment
JohnnyMorganz
left a comment
There was a problem hiding this comment.
Looks reasonable to me. I can only test once I merge
Owner
|
Ah whoops, another syntax error: https://github.com/JohnnyMorganz/StyLua/actions/runs/3039595313/workflow |
Owner
|
Fixed it up, and success! https://github.com/JohnnyMorganz/StyLua/actions/runs/3039649816 |
Contributor
Author
|
Awesome! Thanks for the help getting this shipped! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add c toolchain and instruct cargo to use the right linker for aarch64-linux
Apparently these are required for this target only. I'm not sure how to test a gh release but I think this will work. It worked on my local Ubuntu Jammy environment.