This repository was archived by the owner on Jul 29, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Settings integration #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request adds a new SettingsManager for handling user preferences and enhances the VSCode integration with dynamic updates, localization, and configurable VS Code editions. Key changes include:
- Migrating VSCodePage from ListPage to DynamicListPage with dynamic settings support.
- Integrating localized resources and updating UI strings.
- Refactoring instance loading and command provider to support a preferred VS Code edition.
Reviewed Changes
Copilot reviewed 6 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| VsCode/Pages/VSCodePage.cs | Updated page class for dynamic search and localized UI text, with a refined search algorithm. |
| VsCode/CmdPalVsCodeCommandsProvider.cs | Adjusted to initialize SettingsManager and pass settings to VSCodePage, and updated instance loading. |
| VsCode/Classes/VSCodeWorkspace.cs | Added GetMetadata method for returning localized workspace details. |
| VsCode/Classes/VSCodeHandler.cs | Modified LoadInstances to accept a preferred edition and reverse instance order accordingly. |
| VsCode/Classes/SettingsManager.cs | New class for managing user settings stored in a JSON file with localized resource labels. |
Files not reviewed (4)
- VsCode/CmdPalVsCode.csproj: Language not supported
- VsCode/Properties/Resource.Designer.cs: Language not supported
- VsCode/Properties/Resource.resx: Language not supported
- VsCode/VsCode.sln: Language not supported
Comments suppressed due to low confidence (1)
VsCode/Classes/SettingsManager.cs:26
- The property name 'UseStrichtSearch' appears to be misspelled and should likely be 'UseStrictSearch' for consistency with the intended functionality.
Namespaced(nameof(UseStrichtSearch)),
VsCode/Pages/VSCodePage.cs
Outdated
| } | ||
| else | ||
| { | ||
| // string search contains chracters in order of search value, with optinal random characters between |
Copilot
AI
Apr 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The comments contain spelling errors: 'chracters' should be 'characters' and 'optinal' should be 'optional'.
Suggested change
| // string search contains chracters in order of search value, with optinal random characters between | |
| // string search contains characters in order of search value, with optional random characters between |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
SettingsManagerclass to manage user preferences, enhances theVSCodePagefunctionality with customizable settings, and integrates localized resources for better user experience. Key changes include the addition of settings for strict search and details panel, dynamic filtering based on user preferences, and support for localized strings.New Settings Management:
SettingsManagerclass inVsCode/Classes/SettingsManager.csto handle user preferences such as strict search, details panel visibility, and preferred VS Code edition. These settings are stored in a JSON file and loaded automatically.Enhanced
VSCodePageFunctionality:VSCodePageto useDynamicListPageand added support for dynamic updates based on user settings. Integrated strict search functionality and metadata generation for workspace details.GetMetadatamethod in theVSCodeWorkspaceclass to provide detailed information about workspaces.Localization Support:
Resource.Designer.csfile and embeddedResource.resxto provide localized strings for labels, descriptions, and other UI elements. Updated the project file (CmdPalVsCode.csproj) to include these resources. [1] [2] [3]Integration with VS Code Handler:
VSCodeHandler.LoadInstancesmethod to accept apreferredEditionparameter, allowing users to prioritize either the default or Insider edition of VS Code.Miscellaneous:
CmdPalVsCodeCommandsProviderto use the newSettingsManagerand pass settings toVSCodePage.