Skip to content
This repository was archived by the owner on Jul 29, 2025. It is now read-only.

Conversation

@JonahFintzDev
Copy link
Owner

This pull request introduces a new SettingsManager class to manage user preferences, enhances the VSCodePage functionality with customizable settings, and integrates localized resources for better user experience. Key changes include the addition of settings for strict search and details panel, dynamic filtering based on user preferences, and support for localized strings.

New Settings Management:

  • Added the SettingsManager class in VsCode/Classes/SettingsManager.cs to handle user preferences such as strict search, details panel visibility, and preferred VS Code edition. These settings are stored in a JSON file and loaded automatically.

Enhanced VSCodePage Functionality:

  • Refactored VSCodePage to use DynamicListPage and added support for dynamic updates based on user settings. Integrated strict search functionality and metadata generation for workspace details.
  • Introduced a new GetMetadata method in the VSCodeWorkspace class to provide detailed information about workspaces.

Localization Support:

  • Added a Resource.Designer.cs file and embedded Resource.resx to provide localized strings for labels, descriptions, and other UI elements. Updated the project file (CmdPalVsCode.csproj) to include these resources. [1] [2] [3]

Integration with VS Code Handler:

  • Updated the VSCodeHandler.LoadInstances method to accept a preferredEdition parameter, allowing users to prioritize either the default or Insider edition of VS Code.

Miscellaneous:

  • Updated CmdPalVsCodeCommandsProvider to use the new SettingsManager and pass settings to VSCodePage.

@JonahFintzDev JonahFintzDev added the enhancement New feature or request label Apr 19, 2025
@JonahFintzDev JonahFintzDev requested a review from Copilot April 19, 2025 19:26
@JonahFintzDev JonahFintzDev self-assigned this Apr 19, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds a new SettingsManager for handling user preferences and enhances the VSCode integration with dynamic updates, localization, and configurable VS Code editions. Key changes include:

  • Migrating VSCodePage from ListPage to DynamicListPage with dynamic settings support.
  • Integrating localized resources and updating UI strings.
  • Refactoring instance loading and command provider to support a preferred VS Code edition.

Reviewed Changes

Copilot reviewed 6 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
VsCode/Pages/VSCodePage.cs Updated page class for dynamic search and localized UI text, with a refined search algorithm.
VsCode/CmdPalVsCodeCommandsProvider.cs Adjusted to initialize SettingsManager and pass settings to VSCodePage, and updated instance loading.
VsCode/Classes/VSCodeWorkspace.cs Added GetMetadata method for returning localized workspace details.
VsCode/Classes/VSCodeHandler.cs Modified LoadInstances to accept a preferred edition and reverse instance order accordingly.
VsCode/Classes/SettingsManager.cs New class for managing user settings stored in a JSON file with localized resource labels.
Files not reviewed (4)
  • VsCode/CmdPalVsCode.csproj: Language not supported
  • VsCode/Properties/Resource.Designer.cs: Language not supported
  • VsCode/Properties/Resource.resx: Language not supported
  • VsCode/VsCode.sln: Language not supported
Comments suppressed due to low confidence (1)

VsCode/Classes/SettingsManager.cs:26

  • The property name 'UseStrichtSearch' appears to be misspelled and should likely be 'UseStrictSearch' for consistency with the intended functionality.
Namespaced(nameof(UseStrichtSearch)),

}
else
{
// string search contains chracters in order of search value, with optinal random characters between
Copy link

Copilot AI Apr 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The comments contain spelling errors: 'chracters' should be 'characters' and 'optinal' should be 'optional'.

Suggested change
// string search contains chracters in order of search value, with optinal random characters between
// string search contains characters in order of search value, with optional random characters between

Copilot uses AI. Check for mistakes.
@JonahFintzDev JonahFintzDev linked an issue Apr 19, 2025 that may be closed by this pull request
@JonahFintzDev JonahFintzDev merged commit 3b5fbb3 into main Apr 22, 2025
@JonahFintzDev JonahFintzDev deleted the settings-integration branch April 23, 2025 18:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

**Feature request**: offer the ability to open discovered workspaces in vscode-insiders Plugin returns results that do not match the search term

2 participants