-
-
Notifications
You must be signed in to change notification settings - Fork 304
Adds Austin's R2 Mode to Config Branch, Reworked Bootsel and Config bindings #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Austin's R2 Mode to Config Branch, Reworked Bootsel and Config bindings #87
Conversation
changed to the latest commit hash
Add Rivals 2 Mode
|
Newest commit removes bootsel rework and formatting issues, as well as comments referring to melee mode in config files. |
JonnyHaystack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found some stuff I missed the first time round, also some changes added by this latest commit which shouldn't have been, and I've pointed out where a couple of comments were marked as resolved that were not actually resolved - please check those again.
Config.cpp was autoformatted by clang-format, I can disable that if you prefer the original formatting
JonnyHaystack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're almost there 😅
|
New commit addresses final 2 change requests |
This will allow for end users to hold start while accessing config mode, which will be a much more common occurance than bootsel now that remapping is possible.
Bootsel is still very accessible with the A button on plugin, and also avoids the pitfall of sharing any buttons with common game mode bindings (I find that many users accidentally hold the game mode combos on plugin, which causes bootsel, which can be very confusing for new users). Now holding A is an intentional decision, while accidental holding of a game mode just boots into config mode, a much less overwhelming issue.
This also allows all currently supported GUI remappers (Remapp.ing & Remap.box) to use "hold start while plugging in controller" for the remapper UI's without maintaining widely varying forks for third-party support.
Thank you for your consideration.
Cheers goats