Skip to content

Conversation

@GrammyMoney
Copy link
Contributor

  • Austin added Rivals 2 Mode to config branch
  • Austin added hold R on plugin to clear config file (this change in config.cpp is optional, I have personally disabled it in my fork to avoid accidents)
  • Reworked Config and Bootsel for more "user-friendly" experience now that bootsel is a much rarer input
  1. Bootsel moved to input RT1 (defaults to A in standard OF1 pinout)
  2. Config backend moved to input MB1 (defaults to start in standard OF1 pinout)

This will allow for end users to hold start while accessing config mode, which will be a much more common occurance than bootsel now that remapping is possible.

Bootsel is still very accessible with the A button on plugin, and also avoids the pitfall of sharing any buttons with common game mode bindings (I find that many users accidentally hold the game mode combos on plugin, which causes bootsel, which can be very confusing for new users). Now holding A is an intentional decision, while accidental holding of a game mode just boots into config mode, a much less overwhelming issue.

This also allows all currently supported GUI remappers (Remapp.ing & Remap.box) to use "hold start while plugging in controller" for the remapper UI's without maintaining widely varying forks for third-party support.

Thank you for your consideration.

Cheers goats

@GrammyMoney
Copy link
Contributor Author

Newest commit removes bootsel rework and formatting issues, as well as comments referring to melee mode in config files.

Copy link
Owner

@JonnyHaystack JonnyHaystack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some stuff I missed the first time round, also some changes added by this latest commit which shouldn't have been, and I've pointed out where a couple of comments were marked as resolved that were not actually resolved - please check those again.

Config.cpp was autoformatted by clang-format, I can disable that if you prefer the original formatting
Copy link
Owner

@JonnyHaystack JonnyHaystack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're almost there 😅

@GrammyMoney
Copy link
Contributor Author

New commit addresses final 2 change requests

@JonnyHaystack JonnyHaystack merged commit 82a1810 into JonnyHaystack:configurator Jan 26, 2025
@GrammyMoney GrammyMoney deleted the config-PR branch January 27, 2025 02:35
@JonnyHaystack JonnyHaystack mentioned this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants