Parameterize SQL queries, add pagination guards, and refine presence/memory handling#2
Merged
Josh-wt merged 1 commit intoclaude/understand-codebase-9Fmymfrom Apr 10, 2026
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
limit/offsetvalues.INqueries.Description
paramsarray, and addedlimit/offsetsanitization (Math.max) and parameterizedCOUNT/SELECTqueries.paramsfor time range and optional filters.searchto build a conditionalkindclause, passqueryParamsto the FTS query, and updateaccess_countvia a parameterizedINclause using placeholders.leaveandupdateCursorto operate on a specificparticipantIdand adjusted Pub/Sub events accordingly.participantIdinPresenceLeaveInputandPresenceUpdateCursorInput.Testing
yarn testand the TypeScript compiler (tsc) against the modified packages, and all tests and type checks passed.Codex Task
Summary by cubic
Secured SQL across audit, cost, and memory services by switching to parameterized queries and adding safe pagination. Presence updates now target a single participant, and the presence contracts include
participantIdto prevent noisy broadcasts.Bug Fixes
limit/offset, and used placeholders forCOUNT/SELECTwith correcthasMore.projectId/threadId; reused params for totals, by-provider, and top threads.kindfilter; updatedaccess_countvia a parameterizedINlist.leaveandupdateCursoract onparticipantIdonly; clean up empty thread maps and publish precise events.Migration
participantIdtoPresenceLeaveInputandPresenceUpdateCursorInput.Written for commit 44afa0a. Summary will update on new commits.