Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 0 minutes and 53 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3a2ca3ae7c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }; | ||
| const defaultSqliteClientLoaders = { | ||
| bun: () => import("@effect/sql-sqlite-bun/SqliteClient"), | ||
| bun: () => import("../NodeSqliteClient.ts"), |
There was a problem hiding this comment.
Use Bun-compatible SQLite client for bun runtime
Changing the bun loader to ../NodeSqliteClient.ts makes Bun executions take the Node path that imports node:sqlite, which is not available in Bun, so the server can fail at startup in the default Bun dev flow (apps/server uses bun run src/bin.ts). This is a runtime regression introduced by this commit: previously the Bun branch loaded @effect/sql-sqlite-bun/SqliteClient, which is the Bun-targeted client.
Useful? React with 👍 / 👎.
Motivation
SqlClientavailable and unify the SQLite client import across runtimes.Description
NodeSqliteClientloader so bothbunandnodeuse the same client module.sqliteLayerand merge it withsetupwhile explicitly providingsqliteLayertosetupso thePRAGMAcalls and migrations run with a realSqlClient.:memory:) to ensure consistent behavior.Testing
tsc) and the test suite (pnpm test); both completed successfully.Codex Task
Summary by cubic
Fixes the "service not found" error during SQLite setup by providing a real
SqlClient, unifying the client import forbun/node, and reducing layer conflicts. Migrations and PRAGMA now run reliably in both runtimes.Bug Fixes
NodeSqliteClientloader for bothbunandnode.setupso PRAGMA and migrations run with a realSqlClient, including for:memory:.Refactors
Layer.provideMergeso the runtime SQLite layer is merged beforesetupto reduce service conflicts.Written for commit 1367f54. Summary will update on new commits.