Merged
Conversation
2 tasks
1 task
kianenigma
reviewed
Oct 25, 2019
| @@ -0,0 +1,184 @@ | |||
| #![cfg_attr(not(feature = "std"), no_std)] | |||
Contributor
There was a problem hiding this comment.
Don't we use headers here?
Owner
Author
There was a problem hiding this comment.
I'd like to know more about headers. Do you have a link to read?
I do know if I remove this line, the build fails.
Contributor
There was a problem hiding this comment.
I mean license headers. Probably @shawntabrizi should decide.
kianenigma
reviewed
Oct 25, 2019
kianenigma
reviewed
Oct 25, 2019
kianenigma
reviewed
Oct 25, 2019
kianenigma
reviewed
Oct 25, 2019
kianenigma
reviewed
Oct 25, 2019
Contributor
kianenigma
left a comment
kianenigma
left a comment
There was a problem hiding this comment.
I haven't read in much details but all in all examples looked really good. Appreciated. Would be good if you read our other PR on weight/fee and link as much as you can to this
Co-Authored-By: Amar Singh <asinghchrony@protonmail.com>
Co-Authored-By: Amar Singh <asinghchrony@protonmail.com>
…loper-hub/recipes into joshy-transaction-weights
kianenigma
reviewed
Oct 31, 2019
kianenigma
reviewed
Oct 31, 2019
kianenigma
reviewed
Oct 31, 2019
kianenigma
reviewed
Oct 31, 2019
kianenigma
reviewed
Oct 31, 2019
kianenigma
approved these changes
Oct 31, 2019
Contributor
kianenigma
left a comment
kianenigma
left a comment
There was a problem hiding this comment.
Some final nits but looks good in general and for the first pass.
Co-Authored-By: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
robamler
pushed a commit
to robamler/demo-ml-blockchain-node
that referenced
this pull request
Aug 5, 2021
* Upgrade to v2.0.0-rc4 * Better updates to README Co-authored-by: Joshy Orndorff <JoshOrndorff@users.noreply.github.com> Co-authored-by: Joshy Orndorff <JoshOrndorff@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of the effort to document and exemplify transaction weighting.
It adds several examples of calculating transaction weights using FixedNormal as well as three custom weighting functions.
It also includes a runtime example which provides three (two non-trivial) examples of WeightToFee conversions.
The last item todo is to write about it in the text. I think not much text is needed because there are good docs going into devhub. I considered maybe it should replace https://substrate.dev/recipes/design/econsecurity.html but I'd like @4meta5 's opinion on that.