🛠 Tooling: Is the 'if' in the accessibility-alt-text-bot workflow is needed?

[JoshuaKGoldberg]

Bug Report Checklist

• I have tried restarting my IDE and the issue persists.
• I have pulled the latest main branch of the repository.
• I have searched for related issues and found none that matched my issue.

Overview

Following up on @DerTimonius's #989 (comment): we merged the PR with the if:

create-typescript-app/.github/workflows/accessibility-alt-text-bot.yml

Line 5 in 0558e97

- if: ${{ github.event.issue || github.event.pull_request }}

...but I'm not sure that it's necessary. Are there events from GitHub's on.(issue|issue_comment|pull_request) that don't have github.event.issue || github.event.pull_request?

Additional Info

This feels like something someone could probably answer by looking at the docs and/or experimenting in a temporary repository. But I haven't had the time to try. 😄

Marking as status: accepting prs in case the answer is that the if is unnecessary. But if it is necessary, the right solution would be to close and wontfix this issue.

cc @kendallgassner as fyi / for visibility if you're curious

[kendallgassner]

Oh good point! I think this might be fallout from a refactor i'll file a bug on our end to check it out.

[DerTimonius]

I tried removing the if in a test repo, but there was no comment by the bot on this issue. So apparently it is necessary.

[kendallgassner]

This was surprising to me so I tested it on my end. I realized the README was out of date and if we bump to the latest version: 1.4.0 we do not need the if.

• Related comment
• Related PR

[JoshuaKGoldberg]

Awesome thanks!

[github-actions]

🎉 This is included in version v1.43.0 🎉

The release is available on:

• GitHub releases
• npm package (@latest dist-tag)

Cheers! 📦🚀