Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #502 by updating the projects to support a Java 24 build. Key changes include the removal of obsolete archetype.xml files, addition of requiredProperties in archetype-metadata.xml files, and updates to dependency versions and the Maven compiler settings and workflow to reflect newer Java versions.
Reviewed Changes
Copilot reviewed 52 out of 52 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| archetypes-parent/apptbook-web-archetype/META-INF/maven/archetype.xml | Removal of obsolete archetype definition file |
| archetypes-parent/apptbook-web-archetype/META-INF/maven/archetype-metadata.xml | Added requiredProperties with new configuration options |
| archetypes-parent/apptbook-web-archetype/pom.xml | Updated parent and artifact versions to SNAPSHOT releases |
| archetypes-parent/apptbook-archetype/src/main/resources/archetype-resources/pom.xml | Updated dependency versions to SNAPSHOT releases |
| archetypes-parent/apptbook-archetype/META-INF/maven/archetype.xml | Removal of outdated archetype file |
| archetypes-parent/apptbook-archetype/META-INF/maven/archetype-metadata.xml | Added requiredProperties configuration |
| archetypes-parent/apptbook-archetype/pom.xml | Updated parent and artifact versions in alignment with SNAPSHOT releases |
| archetypes-parent/airline-web-archetype and airline-archetype files | Similar updates including removal of obsolete files and version bumps |
| pom.xml (root) | Updates Maven compiler source/target, plugin versions, dependency versions, and changes to repository configuration |
| grader, family, examples pom.xml files | Updated versions across modules to SNAPSHOT releases |
| .github/workflows/maven.yml | Changed the Java version matrix from [ '17', '22' ] to [ '21', '24' ] |
| <maven.compiler.source>21</maven.compiler.source> | ||
| <maven.compiler.target>21</maven.compiler.target> |
There was a problem hiding this comment.
The POM sets maven.compiler.source and maven.compiler.target to 21, which is inconsistent with the PR title and workflow matrix that indicate a build with Java 24. Consider updating these values to 24 to align with the intended Java version.
| <maven.compiler.source>21</maven.compiler.source> | |
| <maven.compiler.target>21</maven.compiler.target> | |
| <maven.compiler.source>24</maven.compiler.source> | |
| <maven.compiler.target>24</maven.compiler.target> |
There was a problem hiding this comment.
Thanks, but I want to keep Java 21 language and bytecode versions so that students can still use Java 21.
… plugin used by other project archetypes.
Address #502 by building with Java 24.