Add github workflows for storage-node and network tests

[mnaamani]

Added CI checks for linting and build for network-tests and storage-node.
The network-tests checks are expected to fail because the fixes are applied in a separate PR #1001

[Lezek123]

This one isn't part of the Ubuntu job, it also doesn't seem necessary, because yarn workspace storage-node run build (which does the same thing) is part of root package.json postinstall script already (so it's beeing run in each of the jobs after yarn install).

[mnaamani]

good point, will remove

[mnaamani]

also I thought I'd already pushed a second commit to add it to ubuntu job :)

[mnaamani]

fixed in 000e2db

[Lezek123]

It also looks like the storage-node's lint script is ignoring .ts files.
I suggest changing:
"lint": "eslint --ignore-path .gitignore .",
To:
"lint": "eslint --ext .js,.ts --ignore-path .gitignore .",
In storage-node's package.json scripts

[mnaamani]

It also looks like the storage-node's lint script is ignoring .ts files.
I suggest changing:
"lint": "eslint --ignore-path .gitignore .",
To:
"lint": "eslint --ext .js,.ts --ignore-path .gitignore .",
In storage-node's package.json scripts

Aren't those extensions checked by default or do you always have to provide them explicitly?
I'm pretty sure those files have been scanned on prior runs, but I will test and confirm.

cc: @shamil-gadelshin

[Lezek123]

I'm not sure how effective linter with Typescript-specific rules is for .js files, but since not all files are .ts in this workspace yet it may make sense to check both and just decrease some rules error level to warning (the way it's already done) until everything is converted to TypeScript.

[mnaamani]

Yes we had to make quite a few rule tweaking to make the linter happy because that code base is still a hybrid. The plan is to gradually refactor all code to .ts and remove a lot of the rules that were turned off.

[Lezek123]

Aren't those extensions checked by default or do you always have to provide them explicitly?

The documentation says that the default is just .js (https://eslint.org/docs/user-guide/command-line-interface).
Perhaps you've been running yarn workspace @joystream/storage-cli lint which has them configured (but not yarn workspace storage-node lint)

[mnaamani]

okay so with current lint script: I get 328 problems (0 errors, 328 warnings)
and with your suggestion to add the extensions I get: 362 problems (0 errors, 362 warnings)
so clearly some files were not covered.
Will update.

[mnaamani]

Yeah I think you were right about that.

Perhaps you've been running yarn workspace @joystream/storage-cli lint which has them configured (but not yarn workspace storage-node lint)

[Lezek123]

Looks good!