Migrate the node project. by shamil-gadelshin · Pull Request #1126 · Joystream/joystream

shamil-gadelshin · 2020-08-05T10:06:20Z

Node project was converted to the Substrate version 2.0.0rc4

Comments:

build scripts in both runtime and node will be changed during the work on the node_spec_builder.
tracing, telemetry, weights, benchmarking are out of the scope of the current release
runtime API, constants, primitives were moved to separate modules
node executor, service, RPC modules were merged in the single node crate unlike the substrate base implementation

node/src/command.rs

mnaamani · 2020-08-07T14:43:38Z

runtime/src/lib.rs

        Offences: pallet_offences::{Module, Call, Storage, Event},
        RandomnessCollectiveFlip: pallet_randomness_collective_flip::{Module, Call, Storage},
        Sudo: pallet_sudo::{Module, Call, Config<T>, Storage, Event<T>},
+        Contracts: pallet_contracts::{Module, Call, Config, Storage, Event<T>},


Unless we are able to control who can deploy contracts, we should we keep the Contracts module out for now until we decide we need it.

Ok. I'll remove all traces of the contracts pallet.

mnaamani · 2020-08-07T14:45:35Z

runtime/src/runtime_api.rs

+};
+
+/// The SignedExtension to the basic transaction logic.
+pub type SignedExtra = (


If the contracts module is in the runtime, I think there needs to be a signed extension, something about checks on Gas?

I'll remove all traces of the contracts pallet.

mnaamani · 2020-08-08T14:59:48Z

The node is building, runs and with a dev chain blocks are being produced. I'm testing with some scripts here: https://github.com/mnaamani/joystream/tree/iznik-api-examples/api-examples

Based on the latest types library and updated polkadot-js/api as per #1124

Having issues with submitting transactions:

2020-08-08 17:49:46        RPC-CORE: submitExtrinsic(extrinsic: Extrinsic): Hash:: 1002: Verification Error: Execution: Could not convert parameter `tx` between node and runtime: No such variant in enum MultiSignature: RuntimeApi("Execution: Could not convert parameter `tx` between node and runtime: No such variant in
Error: 1002: Verification Error: Execution: Could not convert parameter `tx` between node and runtime: No such variant in enum MultiSignature: RuntimeApi("Execution: Could not convert parameter `tx` between node and runtime: No such variant in

We may not be using the correct version of polkadot-js/api or there is a misconfiguration in the node/runtime

mnaamani · 2020-08-08T15:02:17Z

The travis build is taking very long time to build, and is not completing, so we may need to tweak the .travis.yml file

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received

The build has been terminated

mnaamani · 2020-08-08T15:17:28Z

Having issues with submitting transactions:

Perhaps I'm not properly constructing types ? @Lezek123

Lezek123 · 2020-08-08T19:00:28Z

Tried to reproduce. I used https://github.com/shamil-gadelshin/substrate-runtime-joystream/tree/migrate_runtime_module4 to start a development node and https://github.com/mnaamani/joystream/tree/iznik-api-examples/api-examples to run the scripts.

I ran:
yarn workspace api-examples script injectDataObjects
and then:
yarn workspace api-examples script listDataDirectory
But didn't run into any issues.

The output of the second one also confirmed that:
Data Directory contains 132 objects

mnaamani · 2020-08-10T06:12:39Z

Tried to reproduce. I used https://github.com/shamil-gadelshin/substrate-runtime-joystream/tree/migrate_runtime_module4 to start a development node and https://github.com/mnaamani/joystream/tree/iznik-api-examples/api-examples to run the scripts.

I ran:
yarn workspace api-examples script injectDataObjects
and then:
yarn workspace api-examples script listDataDirectory
But didn't run into any issues.

The output of the second one also confirmed that:
Data Directory contains 132 objects

Those were the steps I followed. I tried rebuilding the node a second time but I'm still getting the same issue.

shamil-gadelshin · 2020-08-10T15:51:30Z

Part of this PR

Lezek123 · 2020-08-11T15:30:12Z

I was able to reproduice @mnaamani's issue by fetching the last commit, which I'm not sure I fetched before (fb9845b)

Then I re-built the runtime using 10fa8dd and the issue didn't occur anymore.

That leads me to think that fb9845b introduced some changes that are causing the mentioned error.

mnaamani · 2020-08-12T05:48:47Z

runtime/src/lib.rs

    type Hashing = BlakeTwo256;
    type AccountId = AccountId;
-    type Lookup = Indices;
+    type Lookup = IdentityLookup<AccountId>;


With this change, as identified by @shamil-gadelshin we were required to add "Address": "AccountId","LookupSource": "AccountId" to the types registration in polkadot-js api, which isn't done automatically by the api library unless it detects the node-template specName in the runtime version.

mnaamani · 2020-08-12T05:50:01Z

That leads me to think that fb9845b introduced some changes that are causing the mentioned error.

You were correct. The change was specifically how the address lookup is done and requires a change in the types registration: https://github.com/Joystream/joystream/pull/1126/files#r469018972

shamil-gadelshin added 5 commits August 3, 2020 12:39

node: Upgrade to the Substrate 2.0.0-rc4

519587e

node: Fix node tests.

13664bb

runtime: Move out code from the lib.rs to the integration module

45657b9

runtime: Move runtime api code to the separate module

15e1181

node: Remove unnecessary dependencies.

10fa8dd

shamil-gadelshin added runtime alexandria-release labels Aug 5, 2020

shamil-gadelshin requested a review from mnaamani August 5, 2020 10:06

shamil-gadelshin self-assigned this Aug 5, 2020

shamil-gadelshin mentioned this pull request Aug 5, 2020

Migrate Runtime to the Substrate version 2.0.0 rc4 #1075

Merged

runtime: Remove migration and indices module.

fb9845b

shamil-gadelshin changed the base branch from substrate_version_upgrade to master August 6, 2020 07:06

shamil-gadelshin changed the base branch from master to substrate_version_upgrade August 6, 2020 07:06

mnaamani reviewed Aug 8, 2020

View reviewed changes

Lezek123 mentioned this pull request Aug 11, 2020

Pioneer - new polkadot-js/apps skeleton #1101

Merged

mnaamani reviewed Aug 12, 2020

View reviewed changes

mnaamani merged commit 46cd91c into Joystream:substrate_version_upgrade Aug 12, 2020

Lezek123 mentioned this pull request Aug 12, 2020

@joystream/types: Rename AccountInfo, make dependencies exact, add types required by new node #1153

Merged

Conversation

shamil-gadelshin commented Aug 5, 2020

Uh oh!

Uh oh!

mnaamani Aug 7, 2020

Choose a reason for hiding this comment

Uh oh!

shamil-gadelshin Aug 10, 2020

Choose a reason for hiding this comment

Uh oh!

mnaamani Aug 7, 2020

Choose a reason for hiding this comment

Uh oh!

shamil-gadelshin Aug 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mnaamani commented Aug 8, 2020

Uh oh!

mnaamani commented Aug 8, 2020

Uh oh!

mnaamani commented Aug 8, 2020

Uh oh!

Lezek123 commented Aug 8, 2020

Uh oh!

mnaamani commented Aug 10, 2020

Uh oh!

shamil-gadelshin commented Aug 10, 2020

Uh oh!

Lezek123 commented Aug 11, 2020

Uh oh!

mnaamani Aug 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mnaamani commented Aug 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

shamil-gadelshin Aug 10, 2020 •

edited

Loading

mnaamani Aug 12, 2020 •

edited

Loading

mnaamani commented Aug 12, 2020 •

edited

Loading