Content directory runtime integration by iorveth · Pull Request #1273 · Joystream/joystream

iorveth · 2020-09-09T15:54:18Z

The scope of this PR includes:

content_directory module runtime integration
content_directory and working_group & membership modules integration related work, implemented through content_directory::ActorAuthenticator trait.

…_integration

shamil-gadelshin · 2020-09-15T11:33:56Z

runtime/src/lib.rs

+    pub const PropertyDescriptionLengthConstraint: InputValidationLengthConstraint = InputValidationLengthConstraint::new(1, 500);
+    pub const ClassNameLengthConstraint: InputValidationLengthConstraint = InputValidationLengthConstraint::new(1, 49);
+    pub const ClassDescriptionLengthConstraint: InputValidationLengthConstraint = InputValidationLengthConstraint::new(1, 500);
+


Do we need spaces between lines?

The purpose is to make constraints of different types distinguishable. I can remove them, though.

Yes, please. Remove or introduce explicit comments for different types.

Done. Removed them in content directory mock.rs as well. d993a64

shamil-gadelshin

We need to implement the working_group for Instance3, check StorageWorkingGroupInstance implementation for details.

shamil-gadelshin · 2020-09-15T11:34:08Z

runtime/src/lib.rs

+    type Nonce = u64;
+    type ClassId = u64;
+    type EntityId = u64;
+


Do we need spaces between lines?

The purpose is to make constraints of different types distinguishable. I can remove them, though.

shamil-gadelshin · 2020-09-15T11:36:10Z

runtime-modules/content-directory/src/permissions.rs


 impl<T: Trait> core::fmt::Debug for Actor<T> {
-    #[cfg(feature = "std")]
    fn fmt(&self, formatter: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {


Why did you remove conditional compilation for this and other Debug implementations>

I still getting errors, related to T: Trait inheritance, when conditional compilation enabled here. I hope this will be fixed with further refactoring.

Ok. Please, keep in mind to remove those implemented traits after the refactoring.

shamil-gadelshin · 2020-09-15T11:36:32Z

runtime-modules/working-group/src/lib.rs

@@ -1298,7 +1298,7 @@ impl<T: Trait<I>, I: Instance> Module<T, I> {
        Ok(worker)
    }



Add a comment for a public method, please.

Done 9d6bbb0

shamil-gadelshin · 2020-09-15T11:38:21Z

runtime/src/integration/content_directory.rs

@@ -0,0 +1,47 @@
+use crate::{AccountId, MemberId, Runtime};
+
+// The content directory working group instance alias.


It is already taken. Take instance3 instead. Also to prevent future errors - please move this line to the lib.rs closer to the Instance2 declaration.

Ok. But i saw, both service-discovery and storage modules are using Instance2 Is that correct case?

Done here b9c741e

Yes. Because they use the same working group.

bedeho

LGTM.

shamil-gadelshin

LGTM

iorveth added 3 commits September 8, 2020 21:59

Add content directory dependency

883e559

Cont dir initial runtime integration work

ed03e80

Merge branch 'cont_directory_debug_trait_implementation' into runtime…

39ef577

…_integration

iorveth self-assigned this Sep 9, 2020

iorveth added the content-pallet label Sep 9, 2020

make MaxNumber type public

af305a8

iorveth changed the base branch from content_directory_second_try to content_dir_2 September 10, 2020 07:03

iorveth changed the base branch from content_dir_2 to content_directory_second_try September 10, 2020 07:03

iorveth added 7 commits September 13, 2020 14:14

Remove redundant traits from content directory trait associated types

33a8c89

Add content directory config

35165d2

Chainspec: Remove unnecessary import

04ae232

Remove class_by_id & entity_by_id from chainspec config

48d4e30

content_directory integration - initial implementation

ae2ef29

Add content_directory integration file

5202cba

content_directory integration: fix is_lead implementation

905fe9e

iorveth marked this pull request as ready for review September 15, 2020 10:47

iorveth requested review from bedeho and shamil-gadelshin September 15, 2020 10:47

shamil-gadelshin reviewed Sep 15, 2020

View reviewed changes

shamil-gadelshin suggested changes Sep 15, 2020

View reviewed changes

bedeho approved these changes Sep 15, 2020

View reviewed changes

iorveth added 2 commits September 15, 2020 17:00

Introduce ContentDirectoryWorkingGroup - Instance3

b9c741e

WorkingGroup: Add missing comment

9d6bbb0

iorveth requested a review from shamil-gadelshin September 15, 2020 14:10

Content directory refactoring: remove unnecessary spaces

d993a64

shamil-gadelshin approved these changes Sep 15, 2020

View reviewed changes

bedeho merged commit 531abfa into Joystream:content_directory_second_try Sep 16, 2020

This was referenced Sep 17, 2020

Content directory integration work, part 1 #1275

Closed

cont dir 2.0 node runtime integration #1055

Closed

Content directory runtime integration related research, part 1 #1281

Closed

		@@ -1298,7 +1298,7 @@ impl<T: Trait<I>, I: Instance> Module<T, I> {
		Ok(worker)
		}

		@@ -0,0 +1,47 @@
		use crate::{AccountId, MemberId, Runtime};

		// The content directory working group instance alias.

Conversation

iorveth commented Sep 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shamil-gadelshin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iorveth Sep 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bedeho left a comment

Choose a reason for hiding this comment

Uh oh!

shamil-gadelshin left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

iorveth commented Sep 9, 2020 •

edited

Loading

iorveth Sep 15, 2020 •

edited

Loading