Merged
Conversation
mnaamani
requested changes
Sep 11, 2020
Member
mnaamani
left a comment
There was a problem hiding this comment.
Looks good.
Just minor request: bump the runtime spec version.
Member
|
Clearly omitting ImOnline module as an EventHandler for the authorship module was a mistake in the past. With respect to the I can't claim to fully understand the significance of 5 vs 0 so selecting the same value used in polkadot and kusama production networks is fine by me. |
mnaamani
approved these changes
Sep 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our current network configuration has unexpected side-effect. In the list of validator who get reward-points for participating in network activities we have special account
5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhMin each era.Example of rewards points for an era:
}
Also neither Kusama nor Polkadot networks have same effects. In those networks all validators got 20xN points where N is blocks for a validator.
This behavior could affect validator payouts but appears to not cause any problems in the network itself.
After an investigation we found out that
5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhMis '0x0' account (zero) and it got rewarded by uncle verification only.0x0 is a outcome of using
Default::default()for account in case of any errors.in some cases, 0x0 is because the node cannot determine an author() of the uncle block, which in turn is set by ImOnline EventHandler implementation.
Further investigation shows that both Kusama and Polkadot have a different configuration.
Having set this configuration for our network we eliminate the issue.