Added set_mint_capacity dispatchable and tests#239
Merged
shamil-gadelshin merged 4 commits intoJoystream:developmentfrom Mar 26, 2020
Merged
Added set_mint_capacity dispatchable and tests#239shamil-gadelshin merged 4 commits intoJoystream:developmentfrom
shamil-gadelshin merged 4 commits intoJoystream:developmentfrom
Conversation
| @@ -2033,6 +2041,41 @@ decl_module! { | |||
| let mint = <minting::Module<T>>::mints(mint_id); // must exist | |||
| let new_capacity = mint.capacity() + additional_capacity; | |||
| let _ = <minting::Module<T>>::set_mint_capacity(mint_id, new_capacity); | |||
Contributor
There was a problem hiding this comment.
I recommend here to add "?":
<minting::Module<T>>::set_mint_capacity(mint_id, new_capacity)?;
Since set_mint_capacity() returns the Result and it's possible that another error would be added later inside it - it's safer to process this error rather than ignore it.
|
|
||
| if new_capacity != current_capacity { | ||
| // Cannot fail if mint exists | ||
| let _ = <minting::Module<T>>::set_mint_capacity(mint_id, new_capacity); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #237