Add replace_lead() to content working group#252
Merged
shamil-gadelshin merged 8 commits intoJoystream:developmentfrom Mar 27, 2020
Merged
Add replace_lead() to content working group#252shamil-gadelshin merged 8 commits intoJoystream:developmentfrom
replace_lead() to content working group#252shamil-gadelshin merged 8 commits intoJoystream:developmentfrom
Conversation
mnaamani
changed the title
replace_lead() to content working group
|
|
||
| // Update next lead counter | ||
| <NextLeadId<T>>::mutate(|id| *id += <LeadId<T> as One>::one()); | ||
|
|
Contributor
There was a problem hiding this comment.
Probably, assert() can be replaced with "?" function invocation. Code reordering is required.
Member
Author
There was a problem hiding this comment.
Thats a good point, I think this is the new convention we decided on. However here I avoided changing the implementation of set_lead and unset_lead I just relocated them and converted them from being dispatchables to be private methods on the Module.
I can update it not much extra work.
|
|
||
| let unregistered_role = <members::Module<T>>::unregister_role(current_lead_role).is_ok(); | ||
|
|
||
| assert!(unregistered_role); |
Contributor
There was a problem hiding this comment.
Probably, assert() can be replaced with "?" function invocation.
…te-runtime-joystream into content-wg-replace-lead
also drop call to can_register_role_on_member() it is called by register_role_on_member()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #243