Olympia. Runtime. Expose allowed lock ID combinations.#3130
Merged
shamil-gadelshin merged 4 commits intoJoystream:olympiafrom Feb 9, 2022
Merged
Olympia. Runtime. Expose allowed lock ID combinations.#3130shamil-gadelshin merged 4 commits intoJoystream:olympiafrom
shamil-gadelshin merged 4 commits intoJoystream:olympiafrom
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/joystream/pioneer-testnet/F6HnNbxB7EFYhqwmRVV6c5XCGyDb [Deployment for d7f0231 canceled] |
Contributor
Author
|
FYI @jodator |
Contributor
3 tasks
3 tasks
mnaamani
requested changes
Feb 7, 2022
Member
mnaamani
left a comment
There was a problem hiding this comment.
Looks good, just needs merge conflict fixes.
AllowedLockCombinationProvider -> AllowedLockCombinations
70f2307 to
d7f0231
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to expose allowed lock ID combinations to the frontend (#2825).
The are several approaches to implement this:
joystreamUtilitypallet's constants. The constant name isAllowedLockCombinations. It returns the set of the allowed lock ID pairs.Fixes: