Configurable vesting pallet#4216
Merged
mnaamani merged 4 commits intoJoystream:carthagefrom Aug 29, 2022
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
bedeho
reviewed
Aug 26, 2022
| pallet-im-online = { package = 'pallet-im-online', default-features = false, git = 'https://github.com/paritytech/substrate.git', rev = '6cbe1772bf258793fa9845daa8f43ea0cadee596'} | ||
| substrate-utility = { package = 'pallet-utility', default-features = false, git = 'https://github.com/paritytech/substrate.git', rev = '6cbe1772bf258793fa9845daa8f43ea0cadee596'} | ||
| pallet-vesting = { package = 'pallet-vesting', default-features = false, git = 'https://github.com/paritytech/substrate.git', rev = '6cbe1772bf258793fa9845daa8f43ea0cadee596'} | ||
| pallet-vesting = { package = 'pallet-vesting', default-features = false, git = 'https://github.com/Lezek123/substrate', rev = '0f2db1b409af534f45aa2b211e5c0c1f96c89ed0' } |
Member
There was a problem hiding this comment.
Added issue to make sure we don't forget to stop using this: #4218
runtime/Cargo.toml
Outdated
| smallvec = "1.6.0" | ||
| log = { version = "0.4.17", default-features = false } | ||
| static_assertions = "1.1.0" | ||
| hashbrown = "^0.12.3" |
Contributor
Author
There was a problem hiding this comment.
It's a leftover from one of the fixes I applied when trying to make the dependencies work together (cargo was failing to resolve hashbrown to a correct version), seems like it's no longer needed, removed in 0aa09f9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #4200 and #4201
WithdrawalReasonsconfigurablepallet_vestingdependency is currently pointing to a commit from the forked substrate repository (namely Lezek123/substrate@0f2db1b). Once the PR is merged to upstream we can make it point directly to Substrate repository.