Staked Roles

[mnaamani]

Builds on membership module, #3

Some refactoring of council elections, and runtime upgrade proposals module to only allow members to participate.

Adding a simple staking mechanism to enter the new roles introduced in athens. It follows a similar mechanism to validator staking, but allows for using a separate account than will be associated with a members account. A member can enter a role (become an actor for a role) with these steps:

1. create a new account/keypair (the actor account)
2. tx: with actor account, register a request to enter a specific role and use a particular member identity
3. tx: (any account) transfer some tokens into actor account
4. tx: using member account, approve request generated in step 2. If there is 'slot' to fill for the role
   and there is enough balance in the actor account it will be bonded and role is entered into.

Still todo:

• paying out rewards
• governance functions to
  • add/udpdate roles and role parameters
  • eject under performing actors
• tests

[siman]

Better to swap a position: first min_actors, then max_actors.
It's easier for perception like in counting: from smaller to bigger.

[siman]

Actually, this is a list of actors' account ids, not Actors

Suggested change

	Actors get(actors) : Vec<T::AccountId>;
	ActorIds get(actor_ids) : Vec<T::AccountId>;

[siman]

Actor, not Actors, because you return option of an actor, not a list of actors.

Suggested change

	ActorsByAccountId get(actors_by_account_id) : map T::AccountId => Option<Actor<T>>;
	ActorByAccountId get(actor_by_account_id) : map T::AccountId => Option<Actor<T>>;

[siman]

Suggested change

	AccountsByRole get(accounts_by_role) : map Role => Vec<T::AccountId>;
	AccountIdsByRole get(account_ids_by_role) : map Role => Vec<T::AccountId>;

[siman]

Suggested change

	AccountsByMember get(accounts_by_member) : map MemberId<T> => Vec<T::AccountId>;
	AccountIdsByMemberId get(account_ids_by_member_id) : map MemberId<T> => Vec<T::AccountId>;

[siman]

Suggested change

	fn role_is_available(role: Role) -> bool {
	fn is_role_available(role: Role) -> bool {

[siman]

Consider creating an extra variable just to make code easier to read, then you can get rid of a comment:

Suggested change

	if now % T::BlockNumber::sa(DEFAULT_REQUEST_CLEARING_INTERVAL) == T::BlockNumber::zero() {
	let is_request_expired = now % T::BlockNumber::sa(DEFAULT_REQUEST_CLEARING_INTERVAL) == T::BlockNumber::zero()
	if is_request_expired {

[mnaamani]

I see you point in general, but in this exact case the that check is just a check to see if we reached the interval where we actually check each request.