CLI: Init working-groups commands family#692
Merged
mnaamani merged 3 commits intoJoystream:nicaeafrom Jun 16, 2020
Merged
Conversation
mnaamani
approved these changes
Jun 16, 2020
Member
mnaamani
left a comment
There was a problem hiding this comment.
Looks good, I tested on linux, still doesn't work on my mac. I only left a comment but it should be good to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #598
Core functionality implemented:
./cli/bin/run working-groupscommands family./cli/bin/run working-groups:overview --group=GROUPcommand that displays working group leader and members/workers information (similar to working group overview in Pioneer)getRequiredLeadandgetRequiredWorkermethods insideWorkingGroupsCommandBaseclass, which serve as both a gate that will prevent users without access (worker/lead) from trying to execute a command that requires it AND a way of retrieving lead/worker entity and member profile information associated with the selected CLI account (since there could be more than 1 worker associated with a given key, there is also a support for choosing one of the available roles in that case)I also introduced a few general improvements:
formatBalanceare now set based on the values provided by the runtime when initializing the api (same way it's done within Pioneer)AliceandBobaccounts as "special" hidden accounts that can be selected using./cli/bin/run accounts:choose --showSpecial(for easier testing)buildscript forjoystream-cliworkspace and fixed thetsconfigissue (jest vs mocha types conflict)