Skip to content

Proposals for the working group management.#754

Merged
bedeho merged 25 commits intoJoystream:nicaeafrom
shamil-gadelshin:working_group_proposals
Jul 2, 2020
Merged

Proposals for the working group management.#754
bedeho merged 25 commits intoJoystream:nicaeafrom
shamil-gadelshin:working_group_proposals

Conversation

@shamil-gadelshin
Copy link
Contributor

@shamil-gadelshin shamil-gadelshin commented Jun 22, 2020

New proposals were created in the proposals codex module.

Proposal list:

  • fill_opening
  • begin_applicant_review
  • add_opening
  • decrease_stake
  • slash_stake
  • set_new_reward_amount
  • set_mint_capacity
  • terminate_role

Notes:

  • the 'accept_applications' was removed from the codebase.
  • proposal parameters could be found here

Parameters validation:

  • decrease_stake (non-zero balance value)
  • slash_stake (non-zero balance value)
  • set_mint_capacity (less than limit - 5000000)

…ntime

- add integration test in the runtime for the create_add_working_group_leader_opening_proposal() extrinsic from the proposal codex module.
Resolved TODO:

// Clippy linter warning. TODO: remove after the Constaninople release
#![allow(clippy::type_complexity)]
// disable it because of possible frontend API break
@shamil-gadelshin shamil-gadelshin requested a review from bedeho July 1, 2020 10:28
@shamil-gadelshin shamil-gadelshin marked this pull request as ready for review July 1, 2020 10:28
Copy link
Member

@bedeho bedeho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!


/// Grace period for the 'spending' proposal
pub SpendingProposalGracePeriod get(spending_proposal_grace_period) config(): T::BlockNumber;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment