@joystream/types: remove need for lib from import path#785
@joystream/types: remove need for lib from import path#785mnaamani merged 6 commits intoJoystream:nicaeafrom
Conversation
|
Doing a test by packing the package with Will try to resolve |
|
Fixed by adding missing dependencies in 26c008f |
There was a problem hiding this comment.
Seems to work fine after removing node_modules inside the root and project folders and running yarn install.
Tested CLI, Pioneer and Network Tests.
Also tried using the tarball created with npm pack within the CLI.
Didn't run into any issues that I could track to changes introduced in this PR.
Merging this will require updates in: #707 (where some additional imports using the old /lib path were included)
types/.gitignore
Outdated
| # Don't track build artifacts | ||
| **/*.js | ||
| **/*.d.ts | ||
| hiring/schemas |
There was a problem hiding this comment.
I'm not sure why this is inlcuded as part of .gitignore
There was a problem hiding this comment.
Added it to ignore the role.schema.json which is moved into there because its imported by src/hiring/index.ts
import * as role_schema_json from './schemas/role.schema.json'
I will be more explicit and make it ignore that exact file.
Lezek123
left a comment
There was a problem hiding this comment.
I confused hiring/schemas with src/hiring/schemas, now it makes sense, I think it's good to go then.
/lib/in the import path.forceConsistentCasingInFileNamestsconfig option which"Disallow inconsistently-cased references to the same file"
This option would have detected the issue we once had on OSX Pioneer: Fix for #511 #514