CLI: Linter fixes

[Lezek123]

Introduces fixes to all linter errors following #917

[mnaamani]

Great!

Can you also run yarn format and check-in the changed files.
The reason the --fix argument when you ran linter didn't sort those out is because the lint script is only linting .ts files /src folder I think.

Perhaps update it the lint script to cover the whole directory. So format, lint, and checks all cover the same files.

Perhaps also update .github/workflows/joystream-cli.yml

to run yarn workspace joystream-cli checks in place of yarn workspace joystream-cli build

[mnaamani]

I think ideally

    "lint": "eslint . --quiet --ext .ts",
    "checks": "yarn lint && tsc --noEmit --pretty && prettier . --check",
    "format": "prettier . --write"

but will need to fix:

/Users/mokhtar/joystream/joystream/cli/test/commands/council/info.test.ts
  3:1  error  'describe' is not defined  no-undef

✖ 1 problem (1 error, 0 warnings)

I think adding mocha to the env in the eslintrc file should do the trick

[Lezek123]

Fixed the mentioned issues.
While testing I noticed the lack of unused imports check for the CLI.
I found this check very helpful in Pioneer. so I added @typescript-eslint/no-unused-vars rule to CLI's .eslintrc.js too. Also set "noUnusedLocals": true in tsconfig.json (the latter will additionaly cause the build to fail if there are any unused imports spotted).

Perhaps this can be part of the common standard?

[mnaamani]

Fixed the mentioned issues.
While testing I noticed the lack of unused imports check for the CLI.
I found this check very helpful in Pioneer. so I added @typescript-eslint/no-unused-vars rule to CLI's .eslintrc.js too. Also set "noUnusedLocals": true in tsconfig.json (the latter will additionaly cause the build to fail if there are any unused imports spotted).

Perhaps this can be part of the common standard?

Yes those rules look very good and can catch a tonne of bugs. I'm surprised the no-unused-vars isn't on by default in the rule-sets we have.

Added reminder in #664