Naming conventions altered for typescript code#976
Merged
mnaamani merged 5 commits intoJoystream:nicaeafrom Jul 22, 2020
Merged
Naming conventions altered for typescript code#976mnaamani merged 5 commits intoJoystream:nicaeafrom
mnaamani merged 5 commits intoJoystream:nicaeafrom
Conversation
mnaamani
reviewed
Jul 22, 2020
| "error", | ||
| { | ||
| selector: 'default', | ||
| format: ['camelCase'], |
Member
There was a problem hiding this comment.
I'm trying to understand the naming-conventions rules:
Is the format array listing what is allowed or considered and error?
Member
|
I presume since these new rules are in #1001 it works as you want. But why did we make an exception for the types library? Can't we have a set of rules that works for the types library and the consuming apps? |
Member
|
The changes are introducing some linter errors in storage node: Let me add add a CI check for the storage node, and do some fixes there before we merge these new rules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applied @Lezek123 suggestion from #970