Update @joystream/types to v0.12.0#988
Merged
mnaamani merged 4 commits intoJoystream:nicaeafrom Jul 21, 2020
Merged
Conversation
Lezek123
approved these changes
Jul 21, 2020
Contributor
Lezek123
left a comment
Lezek123
left a comment
There was a problem hiding this comment.
Couldn't find any issues, but left a comment about some strange change inside yarn.lock
yarn.lock
Outdated
| ajv "^6.11.0" | ||
| lodash "^4.17.15" | ||
| moment "^2.24.0" | ||
| version "0.0.0" |
Contributor
There was a problem hiding this comment.
I'm wondering what happened here
Member
Author
There was a problem hiding this comment.
I agree this looks quite odd. I did have to do some merge conflict resolution on yarn.lock but it wasn't at this line number. It was here: https://github.com/Joystream/joystream/pull/988/files#diff-8ee2343978836a779dc9f8d6b794c3b2R1831 but seems related.
Let me get rid of this section, re-run yarn install and see if all goes well:
"@nicaea/types@link:types":
version "0.0.0"
uid ""
This was referenced Jul 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update example code in @joystream/types README
Bump version to v0.12.0 because I published to npm before updating README, and
--forcepublish is no longer supported so I couldn't force update the README.Updated pioneer/package.json to use
linked path to @joystream/types this way if yarn is run from inside pioneer folder it still works and you get benefit of changes in types library showing up in IDE immediately