Refactor code base to TypeScript (fix #50)#56
Open
huan wants to merge 19 commits intoJsCommunity:masterfrom
Open
Refactor code base to TypeScript (fix #50)#56huan wants to merge 19 commits intoJsCommunity:masterfrom
huan wants to merge 19 commits intoJsCommunity:masterfrom
Conversation
Collaborator
Author
|
ping @julien-f |
Closed
|
@julien-f any chance to see this merged? |
Collaborator
|
Hey everybody, I don't think I will merge this, I'm not proficient enough in TypeScript to feel confident in changing the current code to it. My experience with json-rpc-protocol (which is much simpler) is mixed: since the move to TS I feel uneasy making some changes which would have been trivial in JS just because I don't know to do it without breaking the types. I am open to adding a declaration file though 🙂 @huan Thank you so much for your work and I'm sorry for doing this so late. |
Collaborator
Author
|
@julien-f That's ok for me, thanks for telling me that. And please feel free to let me know when you want to switch to a TypeScript code base! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert the code base to TypeScript #50