feat(tests): Next reaclette tests

[GHEMID-Mohamed]

No description provided.

[julien-f]

What do you think about this?

const isReadOnly = object =>
  !Object.isExtensible(object) &&
  Object.getOwnPropertyNames(object).every(name => {
    const descriptor = Object.getOwnPropertyDescriptor(object, name)
    return (
      !descriptor.configurable &&
      (descriptor.set === undefined || !descriptor.writable)
    )
  })

const store = getRenderArgs()[0]
assert(isReadOnly(store))

const { effects, resetState, state } = store

assert(isReadOnly(effects))
expect(Object.getOwnPropertyNames(effects)).toEqual(['_setState', 'myEffect'])

expect(typeof resetState).toBe('function')

assert(isReadOnly(state))
expect(Object.getOwnPropertyNames(state)).toEqual(['myEntry'])

[GHEMID-Mohamed]

I see that this is very precise. but it's not related with what was the described in the test: receives the store as first param with effects, state and resetState
I will add what you wrote in a new test

[julien-f]

What I described was just a list of ideas of what to test.

Feel free to add, merge and split as necessary.

[GHEMID-Mohamed]

const isReadOnly = object =>
  !Object.isExtensible(object) &&
  Object.getOwnPropertyDescriptors(object).every(
    _ => _.set === undefined || _.writable === false
  )

Every works only with arrays and not with objects

[julien-f]

You're right, you should use Object.keys() with Object.getOwnPropertyDescriptor() then.

[GHEMID-Mohamed]

isReadOnly should be like this:

const isReadOnly = object =>
  !Object.isExtensible(object) &&
  Object.values(Object.getOwnPropertyDescriptors(object)).every(
    _ => _.set === undefined || _.writable === false
  );

and Object.keys(effects) will always be [] (empty) because nothing is enumerable

[GHEMID-Mohamed]

46:3   error  Object.values() is not supported in IE 11                                                                           compat/compat
46:3   error  The 'Object.values' is not supported until Node.js 7.0.0. The configured version range is '>=6'                     node/no-unsupported-features/es-builtins
46:17  error  The 'Object.getOwnPropertyDescriptors' is not supported until Node.js 7.0.0. The configured version range is '>=6'  node/no-unsupported-features/es-builtins

[julien-f]

You're right for Object.keys, I should have said Object.getOwnPropertyNames.

[julien-f]

Easier solution is to use Object.getOwnPropertyNames and Object.getOwnPropertyDescriptor.

[julien-f]

Nope.

[GHEMID-Mohamed]

!