feat(reaclette): Next computed tests#32
Merged
julien-f merged 5 commits intoJsCommunity:nextfrom Mar 13, 2019
Merged
Conversation
julien-f
reviewed
Mar 13, 2019
julien-f
reviewed
Mar 13, 2019
src/new.spec.js
Outdated
| expect(getState().baz).toBe("baz"); | ||
| expect(() => { | ||
| return getState().circularComputed; | ||
| }).toThrowError(new CircularComputedError("circularComputed")); |
Collaborator
There was a problem hiding this comment.
Use toThrow instead as it appear to be the canonical name in Jest's doc.
Collaborator
There was a problem hiding this comment.
Also, I don't see anywhere in the doc that we can pass an error to it.
julien-f
approved these changes
Mar 13, 2019
julien-f
pushed a commit
that referenced
this pull request
Mar 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.