feat(reaclette): effect can be async test#39
Merged
julien-f merged 7 commits intoJsCommunity:nextfrom Mar 19, 2019
Merged
Conversation
julien-f
reviewed
Mar 15, 2019
src/new.spec.js
Outdated
| }, | ||
| }, | ||
| }); | ||
| return expect(effects.foo().then(() => getState().qux)).resolves.toBe( |
Collaborator
There was a problem hiding this comment.
Simplify this line by using await instead of plain promises.
julien-f
reviewed
Mar 18, 2019
Collaborator
julien-f
left a comment
julien-f
left a comment
There was a problem hiding this comment.
I've made some changes, please read, test (and format) and come discuss it with me.
Collaborator
Author
|
Tested and it works fine. The difference that you made is that you added one more test to explicit the asynchronicity of the effect by changing the state twice instead of once 👍 |
julien-f
approved these changes
Mar 19, 2019
julien-f
pushed a commit
that referenced
this pull request
Mar 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.